From: Michael Tokarev <mjt@tls.msk.ru>
To: Ferenc Wagner <wferi@niif.hu>
Cc: Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, Matt Carlson <mcarlson@broadcom.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org
Subject: Re: tg3 driver upgrade (Linux 2.6.32 -> 3.2) breaks IBM Bladecenter SoL
Date: Tue, 02 Oct 2012 23:06:58 +0400 [thread overview]
Message-ID: <506B3B52.7080001@msgid.tls.msk.ru> (raw)
In-Reply-To: <87626sd80j.fsf@lant.ki.iif.hu>
On 02.10.2012 22:49, Ferenc Wagner wrote:
> "Michael Chan" <mchan@broadcom.com> writes:
>> These are the likely fixes:
>>
>> commit cf9ecf4b631f649a964fa611f1a5e8874f2a76db
>> Author: Matt Carlson <mcarlson@broadcom.com>
>> Date: Mon Nov 28 09:41:03 2011 +0000
>>
>> tg3: Fix TSO CAP for 5704 devs w / ASF enabled
>
> You are exactly right: cf9ecf4b fixed the premanent SoL breakage
> introduced by dabc5c67. Looks like ASF utilizes similar technology to
> that of the HS20 BMC. Thanks for the tip, it greatly reduced our CPU
> wear. :) It's a pity ethtool -k did not give a hint. Do you think it's
> possible to work around in 3.2 by eg. fiddling some ethtool setting?
Maybe it's better to push this commit to -stable instead? (the commit
that broke things is part of 3.0 kernel so all current 3.x -stable
kernels are affected)
(Besides, that commit "This patch fixes the problem by revisiting and
reevaluating the decision after tg3_get_eeprom_hw_cfg() is called." -
merely copies a somewhat "twisted" chunk of code into another place,
which does not look optimal)
Thanks,
/mjt
next prev parent reply other threads:[~2012-10-02 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 20:45 Ferenc Wagner
2012-10-01 9:33 ` Michael Chan
2012-10-02 9:31 ` Ferenc Wagner
2012-10-02 12:07 ` Ferenc Wagner
2012-10-02 15:03 ` Michael Chan
2012-10-02 16:49 ` Ferenc Wagner
2012-10-02 17:06 ` Michael Chan
2012-10-02 18:49 ` Ferenc Wagner
2012-10-02 19:06 ` Michael Tokarev [this message]
2012-10-03 0:17 ` Ben Hutchings
2012-10-03 0:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506B3B52.7080001@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®