mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] cputime: Moar cleanups / enhancements
@ 2012-10-08 22:36 Frederic Weisbecker
  2012-10-08 22:36 ` [PATCH 1/3] kvm: Directly account vtime to system on guest switch Frederic Weisbecker
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Frederic Weisbecker @ 2012-10-08 22:36 UTC (permalink / raw)
  To: LKML
  Cc: Frederic Weisbecker, Peter Zijlstra, Ingo Molnar,
	Thomas Gleixner, Tony Luck, Fenghua Yu, Benjamin Herrenschmidt,
	Paul Mackerras, Heiko Carstens, Martin Schwidefsky, Avi Kivity,
	Marcelo Tosatti, Joerg Roedel, Alexander Graf, Xiantao Zhang,
	Christian Borntraeger, Cornelia Huck

Hi,

I think that the 1st and 3rd patches are pretty uncontroversial given
how vtime_account() confusingly tries to do everything for
CONFIG_VIRT_CPU_ACCOUNTING and CONFIG_IRQ_TIME_ACCOUNTING.

I believe the 2nd is also desired. vtime_account() is called
two times per irq, sometimes more if softirqs are involved. So
I think we want to optimize that by calling directly its specialized
APIs when possible.

There is still some work to do but I'm proceeding step by step.
I may focuse more on that generic vtime implementation next
time to implement cputime accounting for the tickmess patchset.
That, for sure, will inspire for even more cputime optimizations/cleanups.

Thanks.

PS: tested on x86 and ppc64 (checked reliability of times and /proc/stat).
But only built tested on s390 and ia64.

Frederic Weisbecker (3):
  kvm: Directly account vtime to system on guest switch
  cputime: Specialize irq vtime hooks
  cputime: Separate irqtime accounting from generic vtime

 arch/ia64/kernel/time.c     |    1 +
 arch/powerpc/kernel/time.c  |    1 +
 arch/s390/kernel/vtime.c    |    4 ++
 include/linux/hardirq.h     |   80 +++++++++++++++++++++++++++++++++++--------
 include/linux/kernel_stat.h |    8 ----
 include/linux/kvm_host.h    |   12 +++++-
 kernel/sched/cputime.c      |    8 ++--
 kernel/softirq.c            |    6 ++--
 8 files changed, 88 insertions(+), 32 deletions(-)

-- 
1.7.5.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-10-08 22:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-08 22:36 [PATCH 0/3] cputime: Moar cleanups / enhancements Frederic Weisbecker
2012-10-08 22:36 ` [PATCH 1/3] kvm: Directly account vtime to system on guest switch Frederic Weisbecker
2012-10-08 22:36 ` [PATCH 2/3] cputime: Specialize irq vtime hooks Frederic Weisbecker
2012-10-08 22:36 ` [PATCH 3/3] cputime: Separate irqtime accounting from generic vtime Frederic Weisbecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®