* [PATCH 1/6] udf: fix memory leak while allocating blocks during write
@ 2012-10-09 15:08 Namjae Jeon
2012-10-11 18:11 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Namjae Jeon @ 2012-10-09 15:08 UTC (permalink / raw)
To: jack; +Cc: linux-kernel, Namjae Jeon, Namjae Jeon, Ashish Sangwan
From: Namjae Jeon <namjae.jeon@samsung.com>
Need to brelse the buffer_head stored in cur_epos and next_epos.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
fs/udf/inode.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/udf/inode.c b/fs/udf/inode.c
index df88b95..2b77593 100644
--- a/fs/udf/inode.c
+++ b/fs/udf/inode.c
@@ -765,6 +765,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
goal, err);
if (!newblocknum) {
brelse(prev_epos.bh);
+ brelse(cur_epos.bh);
+ brelse(next_epos.bh);
*err = -ENOSPC;
return 0;
}
@@ -795,6 +797,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
udf_update_extents(inode, laarr, startnum, endnum, &prev_epos);
brelse(prev_epos.bh);
+ brelse(cur_epos.bh);
+ brelse(next_epos.bh);
newblock = udf_get_pblock(inode->i_sb, newblocknum,
iinfo->i_location.partitionReferenceNum, 0);
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/6] udf: fix memory leak while allocating blocks during write
2012-10-09 15:08 [PATCH 1/6] udf: fix memory leak while allocating blocks during write Namjae Jeon
@ 2012-10-11 18:11 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2012-10-11 18:11 UTC (permalink / raw)
To: Namjae Jeon; +Cc: jack, linux-kernel, Namjae Jeon, Ashish Sangwan
On Wed 10-10-12 00:08:56, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> Need to brelse the buffer_head stored in cur_epos and next_epos.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Thanks. I've merged the patch.
Honza
> ---
> fs/udf/inode.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index df88b95..2b77593 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -765,6 +765,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> goal, err);
> if (!newblocknum) {
> brelse(prev_epos.bh);
> + brelse(cur_epos.bh);
> + brelse(next_epos.bh);
> *err = -ENOSPC;
> return 0;
> }
> @@ -795,6 +797,8 @@ static sector_t inode_getblk(struct inode *inode, sector_t block,
> udf_update_extents(inode, laarr, startnum, endnum, &prev_epos);
>
> brelse(prev_epos.bh);
> + brelse(cur_epos.bh);
> + brelse(next_epos.bh);
>
> newblock = udf_get_pblock(inode->i_sb, newblocknum,
> iinfo->i_location.partitionReferenceNum, 0);
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-11 18:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-09 15:08 [PATCH 1/6] udf: fix memory leak while allocating blocks during write Namjae Jeon
2012-10-11 18:11 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®