mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: j.glisse@gmail.com
To: linux-kernel@vger.kernel.org
Cc: roland@redhat.com, Jerome Glisse <jglisse@redhat.com>
Subject: [PATCH] coredump: always kill the task no matter what
Date: Thu, 11 Oct 2012 15:07:18 -0400	[thread overview]
Message-ID: <1349982438-2062-1-git-send-email-j.glisse@gmail.com> (raw)

From: Jerome Glisse <jglisse@redhat.com>

If do_coredump fails for any reason make sure that the task
is actualy wakeup and properly kill otherwise we endup with
zombies task.

Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
 fs/coredump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/coredump.c b/fs/coredump.c
index fd37fac..4b61468 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -643,11 +643,11 @@ fail_dropcount:
 fail_unlock:
 	kfree(cn.corename);
 fail_corename:
-	coredump_finish(mm);
 	revert_creds(old_cred);
 fail_creds:
 	put_cred(cred);
 fail:
+	coredump_finish(mm);
 	return;
 }
 
-- 
1.7.12.1


             reply	other threads:[~2012-10-11 19:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11 19:07 j.glisse [this message]
2012-10-11 20:04 ` Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349982438-2062-1-git-send-email-j.glisse@gmail.com \
    --to=j.glisse@gmail.com \
    --cc=jglisse@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®