* [PATCH] coredump: always kill the task no matter what
@ 2012-10-11 19:07 j.glisse
2012-10-11 20:04 ` Jerome Glisse
0 siblings, 1 reply; 2+ messages in thread
From: j.glisse @ 2012-10-11 19:07 UTC (permalink / raw)
To: linux-kernel; +Cc: roland, Jerome Glisse
From: Jerome Glisse <jglisse@redhat.com>
If do_coredump fails for any reason make sure that the task
is actualy wakeup and properly kill otherwise we endup with
zombies task.
Signed-off-by: Jerome Glisse <jglisse@redhat.com>
---
fs/coredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index fd37fac..4b61468 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -643,11 +643,11 @@ fail_dropcount:
fail_unlock:
kfree(cn.corename);
fail_corename:
- coredump_finish(mm);
revert_creds(old_cred);
fail_creds:
put_cred(cred);
fail:
+ coredump_finish(mm);
return;
}
--
1.7.12.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] coredump: always kill the task no matter what
2012-10-11 19:07 [PATCH] coredump: always kill the task no matter what j.glisse
@ 2012-10-11 20:04 ` Jerome Glisse
0 siblings, 0 replies; 2+ messages in thread
From: Jerome Glisse @ 2012-10-11 20:04 UTC (permalink / raw)
To: linux-kernel; +Cc: roland, Jerome Glisse
On Thu, Oct 11, 2012 at 3:07 PM, <j.glisse@gmail.com> wrote:
> From: Jerome Glisse <jglisse@redhat.com>
>
> If do_coredump fails for any reason make sure that the task
> is actualy wakeup and properly kill otherwise we endup with
> zombies task.
>
> Signed-off-by: Jerome Glisse <jglisse@redhat.com>
> ---
> fs/coredump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/coredump.c b/fs/coredump.c
> index fd37fac..4b61468 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -643,11 +643,11 @@ fail_dropcount:
> fail_unlock:
> kfree(cn.corename);
> fail_corename:
> - coredump_finish(mm);
> revert_creds(old_cred);
> fail_creds:
> put_cred(cred);
> fail:
> + coredump_finish(mm);
> return;
> }
>
> --
> 1.7.12.1
>
Actually wrong patch, this one does not solve my issue.
Cheers,
Jerome
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-11 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-11 19:07 [PATCH] coredump: always kill the task no matter what j.glisse
2012-10-11 20:04 ` Jerome Glisse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®