mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: lars@metafoo.de, cbou@mail.ru, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Subject: [PATCH 2/4] Use devm_* for request_mem_region and ioremap
Date: Thu, 18 Oct 2012 20:41:02 -0300	[thread overview]
Message-ID: <1350603664-18148-3-git-send-email-marcos.souza.org@gmail.com> (raw)
In-Reply-To: <1350603664-18148-1-git-send-email-marcos.souza.org@gmail.com>

This don't change the rationale, just a cleanup.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 drivers/power/jz4740-battery.c |   15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index 72f6335..9d9b2a8 100644
--- a/drivers/power/jz4740-battery.c
+++ b/drivers/power/jz4740-battery.c
@@ -274,7 +274,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	jz_battery->mem = request_mem_region(jz_battery->mem->start,
+	jz_battery->mem = devm_request_mem_region(&pdev->dev, jz_battery->mem->start,
 				resource_size(jz_battery->mem),	pdev->name);
 	if (!jz_battery->mem) {
 		ret = -EBUSY;
@@ -282,12 +282,12 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	jz_battery->base = ioremap_nocache(jz_battery->mem->start,
+	jz_battery->base = devm_ioremap_nocache(&pdev->dev, jz_battery->mem->start,
 				resource_size(jz_battery->mem));
 	if (!jz_battery->base) {
 		ret = -EBUSY;
 		dev_err(&pdev->dev, "Failed to ioremap mmio memory\n");
-		goto err_release_mem_region;
+		goto err;
 	}
 
 	battery = &jz_battery->battery;
@@ -311,7 +311,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
 			jz_battery);
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to request irq %d\n", ret);
-		goto err_iounmap;
+		goto err;
 	}
 	disable_irq(jz_battery->irq);
 
@@ -368,11 +368,7 @@ err_free_gpio:
 		gpio_free(jz_battery->pdata->gpio_charge);
 err_free_irq:
 	free_irq(jz_battery->irq, jz_battery);
-err_iounmap:
 	platform_set_drvdata(pdev, NULL);
-	iounmap(jz_battery->base);
-err_release_mem_region:
-	release_mem_region(jz_battery->mem->start, resource_size(jz_battery->mem));
 err:
 	return ret;
 }
@@ -393,9 +389,6 @@ static int __devexit jz_battery_remove(struct platform_device *pdev)
 
 	free_irq(jz_battery->irq, jz_battery);
 
-	iounmap(jz_battery->base);
-	release_mem_region(jz_battery->mem->start, resource_size(jz_battery->mem));
-
 	return 0;
 }
 
-- 
1.7.9.5


  parent reply	other threads:[~2012-10-18 23:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 23:41 [PATCH 0/4] driver/power/jz4740-battery: driver cleanup Marcos Paulo de Souza
2012-10-18 23:41 ` [PATCH 1/4] Use devm_kzalloc instead of kzalloc/kfree Marcos Paulo de Souza
2012-10-19  9:21   ` Lars-Peter Clausen
2012-10-18 23:41 ` Marcos Paulo de Souza [this message]
2012-10-19  9:25   ` [PATCH 2/4] Use devm_* for request_mem_region and ioremap Lars-Peter Clausen
2012-10-18 23:41 ` [PATCH 3/4] Use devm_request_irq to avoid some checks Marcos Paulo de Souza
2012-10-19  9:44   ` Lars-Peter Clausen
2012-10-19 14:44     ` Marcos Souza
2012-10-19 16:05       ` Lars-Peter Clausen
2012-10-18 23:41 ` [PATCH 4/4] power/jz4740.c: Simplify exit of function Marcos Paulo de Souza
2012-10-19 12:15   ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350603664-18148-3-git-send-email-marcos.souza.org@gmail.com \
    --to=marcos.souza.org@gmail.com \
    --cc=cbou@mail.ru \
    --cc=dwmw2@infradead.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®