From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: lars@metafoo.de, cbou@mail.ru, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Subject: [PATCH 4/4] power/jz4740.c: Simplify exit of function
Date: Thu, 18 Oct 2012 20:41:04 -0300 [thread overview]
Message-ID: <1350603664-18148-5-git-send-email-marcos.souza.org@gmail.com> (raw)
In-Reply-To: <1350603664-18148-1-git-send-email-marcos.souza.org@gmail.com>
This commit simplifies the exit of probe function, by returning
directly when it don't need to release any resources.
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
drivers/power/jz4740-battery.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/power/jz4740-battery.c b/drivers/power/jz4740-battery.c
index b80f7ed..0d6c9e4 100644
--- a/drivers/power/jz4740-battery.c
+++ b/drivers/power/jz4740-battery.c
@@ -262,32 +262,28 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
jz_battery->irq = platform_get_irq(pdev, 0);
if (jz_battery->irq < 0) {
- ret = jz_battery->irq;
dev_err(&pdev->dev, "Failed to get platform irq: %d\n", ret);
- goto err;
+ return jz_battery->irq;
}
jz_battery->mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!jz_battery->mem) {
- ret = -ENOENT;
dev_err(&pdev->dev, "Failed to get platform mmio resource\n");
- goto err;
+ return -ENOENT;
}
jz_battery->mem = devm_request_mem_region(&pdev->dev, jz_battery->mem->start,
resource_size(jz_battery->mem), pdev->name);
if (!jz_battery->mem) {
- ret = -EBUSY;
dev_err(&pdev->dev, "Failed to request mmio memory region\n");
- goto err;
+ return -EBUSY;
}
jz_battery->base = devm_ioremap_nocache(&pdev->dev, jz_battery->mem->start,
resource_size(jz_battery->mem));
if (!jz_battery->base) {
- ret = -EBUSY;
dev_err(&pdev->dev, "Failed to ioremap mmio memory\n");
- goto err;
+ return -EBUSY;
}
battery = &jz_battery->battery;
@@ -311,7 +307,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
0, pdev->name, jz_battery);
if (ret) {
dev_err(&pdev->dev, "Failed to request irq %d\n", ret);
- goto err;
+ return ret;
}
disable_irq(jz_battery->irq);
@@ -319,7 +315,7 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
ret = gpio_request(pdata->gpio_charge, dev_name(&pdev->dev));
if (ret) {
dev_err(&pdev->dev, "charger state gpio request failed.\n");
- goto err;
+ return ret;
}
ret = gpio_direction_input(pdata->gpio_charge);
if (ret) {
@@ -364,7 +360,6 @@ static int __devinit jz_battery_probe(struct platform_device *pdev)
err_free_gpio:
if (gpio_is_valid(pdata->gpio_charge))
gpio_free(jz_battery->pdata->gpio_charge);
-err:
platform_set_drvdata(pdev, NULL);
return ret;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-10-18 23:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 23:41 [PATCH 0/4] driver/power/jz4740-battery: driver cleanup Marcos Paulo de Souza
2012-10-18 23:41 ` [PATCH 1/4] Use devm_kzalloc instead of kzalloc/kfree Marcos Paulo de Souza
2012-10-19 9:21 ` Lars-Peter Clausen
2012-10-18 23:41 ` [PATCH 2/4] Use devm_* for request_mem_region and ioremap Marcos Paulo de Souza
2012-10-19 9:25 ` Lars-Peter Clausen
2012-10-18 23:41 ` [PATCH 3/4] Use devm_request_irq to avoid some checks Marcos Paulo de Souza
2012-10-19 9:44 ` Lars-Peter Clausen
2012-10-19 14:44 ` Marcos Souza
2012-10-19 16:05 ` Lars-Peter Clausen
2012-10-18 23:41 ` Marcos Paulo de Souza [this message]
2012-10-19 12:15 ` [PATCH 4/4] power/jz4740.c: Simplify exit of function Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350603664-18148-5-git-send-email-marcos.souza.org@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®