From: Tang Chen <tangchen@cn.fujitsu.com>
To: yinghai@kernel.org, bhelgaas@google.com, lenb@kernel.org,
jiang.liu@huawei.com, izumi.taku@jp.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/3] ACPI: container hot remove support.
Date: Wed, 31 Oct 2012 15:27:48 +0800 [thread overview]
Message-ID: <1351668471-31436-1-git-send-email-tangchen@cn.fujitsu.com> (raw)
Hi,
The container hotplug handler container_notify_cb() didn't implement
the hot-remove functionality. So, these 3 patches implement it like
the following way:
patch 1. Do not use kacpid_wq/kacpid_notify_wq to handle container hotplug event,
use kacpi_hotplug_wq instead to avoid deadlock.
Doing this is to reuse acpi_bus_hot_remove_device() in container
hot-remove handling.
patch 2. Introduce a new function container_device_remove() to handle
ACPI_NOTIFY_EJECT_REQUEST event for container.
change log v2 -> v3:
1. Add 1 patch(patch1). As Toshi Kan mentioned, acpi_os_hotplug_execute() is already
kernel. So use it instead of alloc_acpi_hp_work() to add hotplug job onto kacpi_hotplug_wq.
2. In patch3: Print caller's function name when container_device_remove() fails to help to debug.
3. In patch3: Add commit message to describ why we need to call acpi_bus_trim() twice when
removing devices.
change log v1 -> v2:
1. In patch1: Based on the lastest for-pci-split-pci-root-hp-2 branch from Lu Yinghai,
use alloc_acpi_hp_work() to add container hotplug work into kacpi_hotplug_wq.
2. In patch2: Allocate ej_event after container is stopped, so that we don't need to
kfree the ej_event if stopping container failed.
This is based on Lu Yinghai's job.
git://git.kernel.org/pub/scm/linux/kernel/git/yinghai/linux-yinghai.git for-pci-split-pci-root-hp-2
Tang Chen (3):
Use acpi_os_hotplug_execute() instead of alloc_acpi_hp_work().
Use kacpi_hotplug_wq to handle container hotplug event.
Improve container_notify_cb() to support container hot-remove.
drivers/acpi/container.c | 95 +++++++++++++++++++++++++++++++-----
drivers/acpi/osl.c | 28 +++++-----
drivers/acpi/pci_root_hp.c | 25 ++++++---
drivers/pci/hotplug/acpiphp_glue.c | 39 ++++++++-------
include/acpi/acpiosxf.h | 7 +--
5 files changed, 137 insertions(+), 57 deletions(-)
next reply other threads:[~2012-10-31 7:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 7:27 Tang Chen [this message]
2012-10-31 7:27 ` [PATCH v3 1/3] Use acpi_os_hotplug_execute() instead of alloc_acpi_hp_work() Tang Chen
2012-11-01 3:52 ` Yinghai Lu
2012-11-01 6:07 ` Tang Chen
2012-10-31 7:27 ` [PATCH v3 2/3] Use kacpi_hotplug_wq to handle container hotplug event Tang Chen
2012-10-31 7:27 ` [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove Tang Chen
2012-11-01 16:43 ` Toshi Kani
2012-11-01 18:28 ` Yinghai Lu
2012-11-01 19:17 ` Toshi Kani
2012-11-01 20:17 ` Rafael J. Wysocki
2012-11-01 20:16 ` Yinghai Lu
2012-11-01 21:31 ` Rafael J. Wysocki
2012-11-01 21:51 ` Toshi Kani
2012-11-01 22:15 ` Yinghai Lu
2012-11-01 23:15 ` Rafael J. Wysocki
2012-11-01 23:39 ` Yinghai Lu
2012-11-02 1:16 ` Rafael J. Wysocki
2012-11-01 20:16 ` Rafael J. Wysocki
2012-11-02 1:21 ` Tang Chen
2012-10-31 11:09 ` [PATCH v3 0/3] ACPI: container hot remove support Yasuaki Ishimatsu
2012-10-31 16:48 ` Yinghai Lu
2012-11-01 1:48 ` Tang Chen
2012-11-04 16:33 ` Jiang Liu
2012-11-01 1:40 ` Tang Chen
2012-11-26 5:42 ` Hanjun Guo
2012-11-26 6:06 ` Tang Chen
2012-11-26 13:04 ` Hanjun Guo
2012-11-27 1:08 ` Hanjun Guo
2012-11-27 2:38 ` Tang Chen
2012-11-27 11:24 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351668471-31436-1-git-send-email-tangchen@cn.fujitsu.com \
--to=tangchen@cn.fujitsu.com \
--cc=bhelgaas@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=jiang.liu@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®