mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Yinghai Lu <yinghai@kernel.org>, ZhangRui <rui.zhang@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Len Brown <lenb@kernel.org>, Tang Chen <tangchen@cn.fujitsu.com>,
	bhelgaas@google.com, jiang.liu@huawei.com,
	izumi.taku@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
	linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove.
Date: Thu, 01 Nov 2012 15:51:42 -0600	[thread overview]
Message-ID: <1351806702.19172.104.camel@misato.fc.hp.com> (raw)
In-Reply-To: <11976302.Ya3MGGIAsU@vostro.rjw.lan>


> > >> Hi Yinghai,
> > >>
> > >> Per the following thread, the code seems to be written in this way to
> > >> allocate a separate lock_class_key for each work queue.  It should have
> > >> had some comment to explain this, though.
> > >>
> > >> https://lkml.org/lkml/2009/12/13/304
> > >
> > > The code has evolved since then, however, so that it doesn't make sense
> > > any more.
> > >
> > 
> > oh, no, that commit should not be reverted. instead we should add some
> > comment for it...
> > 
> > that mean : three path, will have three separated static lock dep key
> > from every INIT_WORK.
> 
> I see.
> 
> OK, I'll drop the patch removing it.
> 
> What about the following comment:
> 
> "To prevent lockdep from complaining unnecessarily, make sure that there
>  is a different static lockdep key created for each workqueue by using
>  INIT_WORK for each of them separately."

Looks good to me.

Thanks,
-Toshi


> 
> Thanks,
> Rafael
> 
> 



  reply	other threads:[~2012-11-01 21:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31  7:27 [PATCH v3 0/3] ACPI: container hot remove support Tang Chen
2012-10-31  7:27 ` [PATCH v3 1/3] Use acpi_os_hotplug_execute() instead of alloc_acpi_hp_work() Tang Chen
2012-11-01  3:52   ` Yinghai Lu
2012-11-01  6:07     ` Tang Chen
2012-10-31  7:27 ` [PATCH v3 2/3] Use kacpi_hotplug_wq to handle container hotplug event Tang Chen
2012-10-31  7:27 ` [PATCH v3 3/3] Improve container_notify_cb() to support container hot-remove Tang Chen
2012-11-01 16:43   ` Toshi Kani
2012-11-01 18:28     ` Yinghai Lu
2012-11-01 19:17       ` Toshi Kani
2012-11-01 20:17         ` Rafael J. Wysocki
2012-11-01 20:16           ` Yinghai Lu
2012-11-01 21:31             ` Rafael J. Wysocki
2012-11-01 21:51               ` Toshi Kani [this message]
2012-11-01 22:15               ` Yinghai Lu
2012-11-01 23:15                 ` Rafael J. Wysocki
2012-11-01 23:39                   ` Yinghai Lu
2012-11-02  1:16                     ` Rafael J. Wysocki
2012-11-01 20:16       ` Rafael J. Wysocki
2012-11-02  1:21     ` Tang Chen
2012-10-31 11:09 ` [PATCH v3 0/3] ACPI: container hot remove support Yasuaki Ishimatsu
2012-10-31 16:48   ` Yinghai Lu
2012-11-01  1:48     ` Tang Chen
2012-11-04 16:33     ` Jiang Liu
2012-11-01  1:40   ` Tang Chen
2012-11-26  5:42   ` Hanjun Guo
2012-11-26  6:06     ` Tang Chen
2012-11-26 13:04       ` Hanjun Guo
2012-11-27  1:08       ` Hanjun Guo
2012-11-27  2:38         ` Tang Chen
2012-11-27 11:24           ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351806702.19172.104.camel@misato.fc.hp.com \
    --to=toshi.kani@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhelgaas@google.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=jiang.liu@huawei.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome