mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpio: adnp: Depend on OF_GPIO instead of OF
@ 2012-11-01 10:22 Thierry Reding
  2012-11-04 18:08 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Thierry Reding @ 2012-11-01 10:22 UTC (permalink / raw)
  To: Linus Walleij; +Cc: Fengguang Wu, Jamie Lentin, Jason Cooper, linux-kernel

The driver accesses the of_node field of struct gpio_chip, which is only
available if OF_GPIO is selected. This solves a build issue on SPARC
which conflicts with OF_GPIO and therefore does not provide this field.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d055cee..c856f9e 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -466,7 +466,7 @@ config GPIO_ADP5588_IRQ
 
 config GPIO_ADNP
 	tristate "Avionic Design N-bit GPIO expander"
-	depends on I2C && OF
+	depends on I2C && OF_GPIO
 	help
 	  This option enables support for N GPIOs found on Avionic Design
 	  I2C GPIO expanders. The register space will be extended by powers
-- 
1.8.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio: adnp: Depend on OF_GPIO instead of OF
  2012-11-01 10:22 [PATCH] gpio: adnp: Depend on OF_GPIO instead of OF Thierry Reding
@ 2012-11-04 18:08 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-11-04 18:08 UTC (permalink / raw)
  To: Thierry Reding; +Cc: Fengguang Wu, Jamie Lentin, Jason Cooper, linux-kernel

On Thu, Nov 1, 2012 at 11:22 AM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:

> The driver accesses the of_node field of struct gpio_chip, which is only
> available if OF_GPIO is selected. This solves a build issue on SPARC
> which conflicts with OF_GPIO and therefore does not provide this field.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

Thanks! Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-11-04 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-01 10:22 [PATCH] gpio: adnp: Depend on OF_GPIO instead of OF Thierry Reding
2012-11-04 18:08 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome