From: Matt Fleming <matt@console-pimps.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Corentin Chary <corentincj@iksaif.net>,
Matthew Garrett <mjg@redhat.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Alessandro Crismani <alessandro.crismani@gmail.com>,
Mikhail Bakhterev <mike.bakhterev@gmail.com>,
Patrick H <kernel@feystorm.net>, "H. Peter Anvin" <hpa@zytor.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y
Date: Sun, 04 Nov 2012 20:58:44 +0000 [thread overview]
Message-ID: <1352062724.14888.206.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20121104174713.GA28414@elie.Belkin>
On Sun, 2012-11-04 at 09:47 -0800, Jonathan Nieder wrote:
> Matt Fleming wrote:
>
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -717,7 +717,7 @@ config XO15_EBOOK
> >
> > config SAMSUNG_LAPTOP
> > tristate "Samsung Laptop driver"
> > - depends on X86
> > + depends on X86 && !EFI
>
> That means distros would just not get the samsung-laptop driver.
> Is there a runtime check that could be used instead?
Well, the closest thing we have at the moment is the 'efi_enabled'
variable, but that doesn't actually mean "We were booted from EFI?", it
means "Do we have EFI runtime services?", and that's not a broad enough
check for this case. We don't have access to the EFI runtime services
when a 64-bit kernel is booted from 32-bit EFI firmware or vice-versa.
Notably the chromebooks use this scheme. And seeing as Samsung make
chromebooks, I'm not convinced we won't hit that case.
But yeah, you've got a valid point. Clearly we need a way to check this
at runtime. I'll repsin this patch.
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2012-11-04 20:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 17:35 Matt Fleming
2012-11-04 17:44 ` Corentin Chary
2012-11-04 19:37 ` Alan Cox
2012-11-05 9:12 ` Corentin Chary
2012-11-05 10:30 ` Greg KH
2012-11-05 11:50 ` Matt Fleming
2012-11-05 12:07 ` Alan Cox
2012-11-05 12:09 ` Matt Fleming
2012-11-05 12:12 ` Matt Fleming
2012-11-05 12:13 ` Matt Fleming
2012-11-04 17:47 ` Jonathan Nieder
2012-11-04 20:58 ` Matt Fleming [this message]
2012-11-05 10:37 ` Greg KH
2012-11-05 12:09 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352062724.14888.206.camel@mfleming-mobl1.ger.corp.intel.com \
--to=matt@console-pimps.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alessandro.crismani@gmail.com \
--cc=corentincj@iksaif.net \
--cc=hpa@zytor.com \
--cc=jrnieder@gmail.com \
--cc=kernel@feystorm.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.bakhterev@gmail.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®