From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Corentin Chary <corentincj@iksaif.net>
Cc: Matt Fleming <matt@console-pimps.org>,
Matthew Garrett <mjg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Alessandro Crismani <alessandro.crismani@gmail.com>,
Mikhail Bakhterev <mike.bakhterev@gmail.com>,
Patrick H <kernel@feystorm.net>,
Matt Fleming <matt.fleming@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y
Date: Sun, 4 Nov 2012 19:37:41 +0000 [thread overview]
Message-ID: <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAHR064isMXk8qkqhBJ==9sRRP7xC_j_K5rqXApza-LNkosp5mg@mail.gmail.com>
> Acked-by: Corentin Chary <corentin.chary@gmail.com>
This is totally bogus and prevents users build a kernel which can work in
either mode. As such its a regression.
Do the detection check at runtime. If it was booted via EFI then don't
grovel in places you shouldn't. Indeed its possible EFI should reserve
those memory regions ?
Alan
next prev parent reply other threads:[~2012-11-04 19:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 17:35 Matt Fleming
2012-11-04 17:44 ` Corentin Chary
2012-11-04 19:37 ` Alan Cox [this message]
2012-11-05 9:12 ` Corentin Chary
2012-11-05 10:30 ` Greg KH
2012-11-05 11:50 ` Matt Fleming
2012-11-05 12:07 ` Alan Cox
2012-11-05 12:09 ` Matt Fleming
2012-11-05 12:12 ` Matt Fleming
2012-11-05 12:13 ` Matt Fleming
2012-11-04 17:47 ` Jonathan Nieder
2012-11-04 20:58 ` Matt Fleming
2012-11-05 10:37 ` Greg KH
2012-11-05 12:09 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104193741.7b4ca37b@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alessandro.crismani@gmail.com \
--cc=corentincj@iksaif.net \
--cc=hpa@zytor.com \
--cc=kernel@feystorm.net \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=mike.bakhterev@gmail.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®