* [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-saa7115.c
@ 2012-11-05 11:35 YAMANE Toshiaki
2012-11-05 11:36 ` [PATCH 2/2] staging/media: Use dev_ or pr_ printks " YAMANE Toshiaki
0 siblings, 1 reply; 2+ messages in thread
From: YAMANE Toshiaki @ 2012-11-05 11:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-media; +Cc: linux-kernel, YAMANE Toshiaki
fixed below checkpatch error.
- ERROR: that open brace { should be on the previous line
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
drivers/staging/media/go7007/wis-saa7115.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/go7007/wis-saa7115.c b/drivers/staging/media/go7007/wis-saa7115.c
index 46cff59..b31a82b 100644
--- a/drivers/staging/media/go7007/wis-saa7115.c
+++ b/drivers/staging/media/go7007/wis-saa7115.c
@@ -32,8 +32,7 @@ struct wis_saa7115 {
int hue;
};
-static u8 initial_registers[] =
-{
+static u8 initial_registers[] = {
0x01, 0x08,
0x02, 0xc0,
0x03, 0x20,
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] staging/media: Use dev_ or pr_ printks in go7007/wis-saa7115.c
2012-11-05 11:35 [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-saa7115.c YAMANE Toshiaki
@ 2012-11-05 11:36 ` YAMANE Toshiaki
0 siblings, 0 replies; 2+ messages in thread
From: YAMANE Toshiaki @ 2012-11-05 11:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-media; +Cc: linux-kernel, YAMANE Toshiaki
fixed below checkpatch warnings.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ...
Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
drivers/staging/media/go7007/wis-saa7115.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/go7007/wis-saa7115.c b/drivers/staging/media/go7007/wis-saa7115.c
index b31a82b..72d5ad9 100644
--- a/drivers/staging/media/go7007/wis-saa7115.c
+++ b/drivers/staging/media/go7007/wis-saa7115.c
@@ -414,12 +414,12 @@ static int wis_saa7115_probe(struct i2c_client *client,
dec->hue = 0;
i2c_set_clientdata(client, dec);
- printk(KERN_DEBUG
+ dev_dbg(&client->dev,
"wis-saa7115: initializing SAA7115 at address %d on %s\n",
client->addr, adapter->name);
if (write_regs(client, initial_registers) < 0) {
- printk(KERN_ERR
+ dev_err(&client->dev,
"wis-saa7115: error initializing SAA7115\n");
kfree(dec);
return -ENODEV;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-05 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-05 11:35 [PATCH 1/2] Staging/media: fixed spacing coding style in go7007/wis-saa7115.c YAMANE Toshiaki
2012-11-05 11:36 ` [PATCH 2/2] staging/media: Use dev_ or pr_ printks " YAMANE Toshiaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®