From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: warn about using CONFIG_EXPERIMENTAL
Date: Mon, 12 Nov 2012 15:19:16 -0800 [thread overview]
Message-ID: <1352762356.18715.23.camel@joe-AO722> (raw)
In-Reply-To: <CAGXu5jLyWv6jN_iQ+NvDMy5f2o_AN2eJTQGpOzshB3VSnL1pOg@mail.gmail.com>
On Mon, 2012-11-12 at 15:11 -0800, Kees Cook wrote:
> On Mon, Nov 12, 2012 at 3:06 PM, Joe Perches <joe@perches.com> wrote:
> > On Mon, 2012-11-12 at 14:50 -0800, Kees Cook wrote:
> >> + WARN("CONFIG_EXPERIMENTAL",
> >> + "Use of CONFIG_EXPERIMENTAL is deprecated. " +
> >> + "For alternatives, see " +
> >> + "https://lkml.org/lkml/2012/10/23/580\n");
> >
> > I'd much prefer this be on a single line and not using the +
> > string operator as that style is not currently used in checkpatch.
>
> Hah. Okay. We should exclude checkpatch.pl from the 80 character check
> it warns about. ;)
;)
checkpatch is for .[ch] files, it isn't for anything else really.
prev parent reply other threads:[~2012-11-12 23:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 22:50 Kees Cook
2012-11-12 23:06 ` Joe Perches
2012-11-12 23:11 ` Kees Cook
2012-11-12 23:19 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352762356.18715.23.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®