From: Kumar Amit Mehta <gmate.amit@gmail.com>
To: gregkh@linuxfoundation.org
Cc: wfp5p@virginia.edu, geert@linux-m68k.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails
Date: Wed, 14 Nov 2012 13:11:18 +0530 [thread overview]
Message-ID: <1352878879-19840-1-git-send-email-gmate.amit@gmail.com> (raw)
Inspect the return value of get_user() and return -EFAULT on error.
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/dgrp/dgrp_tty.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c
index b294197..720940f 100644
--- a/drivers/staging/dgrp/dgrp_tty.c
+++ b/drivers/staging/dgrp/dgrp_tty.c
@@ -2286,7 +2286,8 @@ static int set_modem_info(struct ch_struct *ch, unsigned int command,
if (error == 0)
return -EFAULT;
- get_user(arg, (unsigned int __user *) value);
+ if (get_user(arg, (unsigned int __user *) value))
+ return -EFAULT;
mval |= ((arg & TIOCM_RTS) ? DM_RTS : 0)
| ((arg & TIOCM_DTR) ? DM_DTR : 0);
@@ -2626,7 +2627,8 @@ static int dgrp_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
return 0;
case TIOCSSOFTCAR:
- get_user(arg, (unsigned long __user *) arg);
+ if (get_user(arg, (unsigned long __user *) arg))
+ return -EFAULT;
tty->termios.c_cflag =
((tty->termios.c_cflag & ~CLOCAL) |
(arg ? CLOCAL : 0));
@@ -2864,7 +2866,8 @@ static int dgrp_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
{
int new_rate;
- get_user(new_rate, (unsigned int __user *) arg);
+ if (get_user(new_rate, (unsigned int __user *) arg))
+ return -EFAULT;
dgrp_set_custom_speed(ch, new_rate);
break;
--
1.7.9.5
next reply other threads:[~2012-11-14 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 7:41 Kumar Amit Mehta [this message]
2012-11-14 11:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352878879-19840-1-git-send-email-gmate.amit@gmail.com \
--to=gmate.amit@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome