From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Kumar Amit Mehta <gmate.amit@gmail.com>
Cc: gregkh@linuxfoundation.org, wfp5p@virginia.edu,
geert@linux-m68k.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: dgrp: dgrp_tty.c: return an -EFAULT if get_user() fails
Date: Wed, 14 Nov 2012 11:55:32 +0000 [thread overview]
Message-ID: <20121114115532.5b4fa80d@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1352878879-19840-1-git-send-email-gmate.amit@gmail.com>
On Wed, 14 Nov 2012 13:11:18 +0530
Kumar Amit Mehta <gmate.amit@gmail.com> wrote:
> Inspect the return value of get_user() and return -EFAULT on error.
You cam just delete all the TIOCSOFTCAR nonsense. That ioctl is handled
correctly by the core tty layer code rather than incorrectly by the dgrp
driver.
Alan
prev parent reply other threads:[~2012-11-14 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 7:41 Kumar Amit Mehta
2012-11-14 11:55 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114115532.5b4fa80d@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome