[PATCH] Remove unnecessary declarations from Documentation/accounting/getdelays.c

[PATCH] Remove unnecessary declarations from Documentation/accounting/getdelays.c

[Anthony G. Basile]

From: "Anthony G. Basile" <basile@opensource.dyc.edu>

stime and utime are declared __u64 but are never used.  On a glibc system
this is harmless lint, but on a uClibc system, because of the difference
in they way header files stack, including stdio.h brings in time.h and
this causes a name collision with stime.  Since these are useless anyhow,
we remove them.

Signed-off-by: Anthony G. Basile <basile@opensource.dyc.edu>
---
 Documentation/accounting/getdelays.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
index 6f706ac..f8ebcde 100644
--- a/Documentation/accounting/getdelays.c
+++ b/Documentation/accounting/getdelays.c
@@ -51,7 +51,6 @@ int dbg;
 int print_delays;
 int print_io_accounting;
 int print_task_context_switch_counts;
-__u64 stime, utime;
 
 #define PRINTF(fmt, arg...) {			\
 	    if (dbg) {				\
-- 
1.7.6.1

Re: [PATCH] Remove unnecessary declarations from Documentation/accounting/getdelays.c

[Jesper Juhl]

On Sat, 24 Nov 2012, Anthony G. Basile wrote:

> From: "Anthony G. Basile" <basile@opensource.dyc.edu>
> 
> stime and utime are declared __u64 but are never used.  On a glibc system
> this is harmless lint, but on a uClibc system, because of the difference
> in they way header files stack, including stdio.h brings in time.h and
> this causes a name collision with stime.  Since these are useless anyhow,
> we remove them.
> 
> Signed-off-by: Anthony G. Basile <basile@opensource.dyc.edu>
> ---
>  Documentation/accounting/getdelays.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index 6f706ac..f8ebcde 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -51,7 +51,6 @@ int dbg;
>  int print_delays;
>  int print_io_accounting;
>  int print_task_context_switch_counts;
> -__u64 stime, utime;
>  
>  #define PRINTF(fmt, arg...) {			\
>  	    if (dbg) {				\
> 

Seems fine to me...

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] Remove unnecessary declarations from Documentation/accounting/getdelays.c

[Jiri Kosina]

On Sat, 24 Nov 2012, Anthony G. Basile wrote:

> From: "Anthony G. Basile" <basile@opensource.dyc.edu>
> 
> stime and utime are declared __u64 but are never used.  On a glibc system
> this is harmless lint, but on a uClibc system, because of the difference
> in they way header files stack, including stdio.h brings in time.h and
> this causes a name collision with stime.  Since these are useless anyhow,
> we remove them.
> 
> Signed-off-by: Anthony G. Basile <basile@opensource.dyc.edu>
> ---
>  Documentation/accounting/getdelays.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c
> index 6f706ac..f8ebcde 100644
> --- a/Documentation/accounting/getdelays.c
> +++ b/Documentation/accounting/getdelays.c
> @@ -51,7 +51,6 @@ int dbg;
>  int print_delays;
>  int print_io_accounting;
>  int print_task_context_switch_counts;
> -__u64 stime, utime;

Taking this through trivial.git, thanks.

-- 
Jiri Kosina
SUSE Labs