From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <andi@firstfloor.org>,
Namhyung Kim <namhyung.kim@lge.com>
Subject: [PATCH 05/18] perf tools: Fix typo on hist__entry_add_pair
Date: Thu, 29 Nov 2012 15:38:33 +0900 [thread overview]
Message-ID: <1354171126-14387-7-git-send-email-namhyung@kernel.org> (raw)
In-Reply-To: <1354171126-14387-1-git-send-email-namhyung@kernel.org>
From: Namhyung Kim <namhyung.kim@lge.com>
Fix a misplaced underscore. In this case, 'hist_entry' is the name of
data structure and we usually put double underscores between data
structure and actual function name.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/hist.c | 4 ++--
tools/perf/util/sort.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
index cb17e2a8c6ed..d2bc05cd1708 100644
--- a/tools/perf/util/hist.c
+++ b/tools/perf/util/hist.c
@@ -785,7 +785,7 @@ void hists__match(struct hists *leader, struct hists *other)
pair = hists__find_entry(other, pos);
if (pair)
- hist__entry_add_pair(pos, pair);
+ hist_entry__add_pair(pos, pair);
}
}
@@ -806,7 +806,7 @@ int hists__link(struct hists *leader, struct hists *other)
pair = hists__add_dummy_entry(leader, pos);
if (pair == NULL)
return -1;
- hist__entry_add_pair(pair, pos);
+ hist_entry__add_pair(pair, pos);
}
}
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index b4e8c3ba559d..91ae2744e7d5 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -118,7 +118,7 @@ static inline struct hist_entry *hist_entry__next_pair(struct hist_entry *he)
return NULL;
}
-static inline void hist__entry_add_pair(struct hist_entry *he,
+static inline void hist_entry__add_pair(struct hist_entry *he,
struct hist_entry *pair)
{
list_add_tail(&he->pairs.head, &pair->pairs.node);
--
1.7.11.7
next prev parent reply other threads:[~2012-11-29 6:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 6:38 [PATCH 00/18] perf report: Add support for event group view (v6) Namhyung Kim
2012-11-29 6:38 ` Namhyung Kim
2012-11-29 12:21 ` Jiri Olsa
2012-11-29 6:38 ` [PATCH 01/18] perf evsel: Set leader evsel's ->leader to itself Namhyung Kim
2012-11-29 14:28 ` Jiri Olsa
2013-01-24 18:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-29 6:38 ` [PATCH 02/18] perf evsel: Convert to _is_group_leader method Namhyung Kim
2012-11-29 14:28 ` Jiri Olsa
2013-01-24 18:49 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-29 6:38 ` [PATCH 03/18] perf tools: Keep group information Namhyung Kim
2012-11-29 14:33 ` Jiri Olsa
2012-11-29 14:58 ` Namhyung Kim
2012-11-29 15:02 ` Jiri Olsa
2012-11-29 15:09 ` Namhyung Kim
2012-11-29 19:09 ` Arnaldo Carvalho de Melo
2012-12-03 1:12 ` Namhyung Kim
2012-11-29 6:38 ` [PATCH 04/18] perf header: Add HEADER_GROUP_DESC feature Namhyung Kim
2012-11-29 18:43 ` Arnaldo Carvalho de Melo
2012-12-03 1:16 ` Namhyung Kim
2012-11-29 6:38 ` Namhyung Kim [this message]
2012-11-29 14:33 ` [PATCH 05/18] perf tools: Fix typo on hist__entry_add_pair Jiri Olsa
2012-11-29 6:38 ` [PATCH 06/18] perf hists: Link hist entry pairs to leader Namhyung Kim
2013-01-24 18:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-29 6:38 ` [PATCH 07/18] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-11-29 18:52 ` Arnaldo Carvalho de Melo
2012-12-03 1:41 ` Namhyung Kim
2012-12-03 10:19 ` Jiri Olsa
2012-12-03 10:49 ` Namhyung Kim
2012-11-29 6:38 ` [PATCH 08/18] perf hists: Add hists__{match,link}_collapsed Namhyung Kim
2012-11-29 6:38 ` [PATCH 09/18] perf symbol: Introduce symbol_conf.event_group Namhyung Kim
2012-11-29 6:38 ` [PATCH 10/18] perf report: Make another loop for linking group hists Namhyung Kim
2012-11-29 6:38 ` [PATCH 11/18] perf hists: Resort hist entries using group members for output Namhyung Kim
2012-11-29 6:38 ` [PATCH 12/18] perf ui/hist: Add support for event group view Namhyung Kim
[not found] ` <20121130132943.GC1080@krava.brq.redhat.com>
2012-11-30 13:52 ` Arnaldo Carvalho de Melo
2012-12-03 1:51 ` Namhyung Kim
2012-12-04 9:16 ` Namhyung Kim
2012-12-04 13:50 ` Arnaldo Carvalho de Melo
2012-12-04 14:51 ` Namhyung Kim
2012-12-03 1:56 ` Namhyung Kim
2012-12-03 10:23 ` Jiri Olsa
2012-12-03 10:39 ` Namhyung Kim
2012-12-03 15:57 ` Jiri Olsa
2012-12-03 16:19 ` Namhyung Kim
2012-11-29 6:38 ` [PATCH 13/18] perf hist browser: " Namhyung Kim
2012-11-29 6:38 ` [PATCH 14/18] perf gtk/browser: " Namhyung Kim
2012-11-29 6:38 ` [PATCH 15/18] perf report: Bypass non-leader events when event group is enabled Namhyung Kim
2012-11-29 6:38 ` [PATCH 16/18] perf report: Show group description " Namhyung Kim
2012-11-29 6:38 ` [PATCH 17/18] perf report: Add --group option Namhyung Kim
2012-11-29 6:38 ` [PATCH 18/18] perf report: Add report.group config option Namhyung Kim
2012-11-29 6:44 ` [PATCH 00/18] perf report: Add support for event group view (v6) Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354171126-14387-7-git-send-email-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®