Re: [PATCH 03/18] perf tools: Keep group information

[Namhyung Kim <namhyung@kernel.org>]

Hi Arnaldo,

On Thu, 29 Nov 2012 16:09:22 -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Nov 30, 2012 at 12:09:11AM +0900, Namhyung Kim escreveu:
>> 2012-11-29 (목), 16:02 +0100, Jiri Olsa:
>> > > You mean adding 'evsel->nr_members > 1' to this function?  For some
>> > > reason, I'd like to treat non-group events as group leaders so I dropped
>> > > that check from the function.
>> > 
>> > nope, the change is ok, I meant updating automated tests in tests/parse-events.c
>> 
>> Ah, okay.  Always forgot to update the test. :(  Will add.
>
> Also consider adding more tests, perhaps for the formatting, i.e.
> calling those hpp functions and then checking that the resulting
> formatted string is the one expected.
>
> One thing I need to do is to create a test that uses slang to write a
> line with callchains and then, without updating the screen, check if
> what is buffered to refresh the screen is what we expect, so that we can
> check that that '+' char isn't lost like it happened twice :-)

Yep, will try.

Thanks,
Namhyung