* [PATCH] staging: csr: remove unneeded call to memset().
@ 2012-12-04 20:41 Cyril Roelandt
0 siblings, 0 replies; only message in thread
From: Cyril Roelandt @ 2012-12-04 20:41 UTC (permalink / raw)
To: linux-kernel
Cc: kernel-janitors, gregkh, devendra.aaru, marcos.souza.org,
andriy.shevchenko, devel, Cyril Roelandt
In uf_send_pkt_to_encrypt(), the memory area zeroed by this call to memset() is
overwritten by a call to memcpy() a few instructions later, so it is not needed.
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
---
drivers/staging/csr/unifi_sme.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/csr/unifi_sme.c b/drivers/staging/csr/unifi_sme.c
index 7c6c413..7669037 100644
--- a/drivers/staging/csr/unifi_sme.c
+++ b/drivers/staging/csr/unifi_sme.c
@@ -1196,7 +1196,6 @@ void uf_send_pkt_to_encrypt(struct work_struct *work)
if (pktBulkDataLength > 0) {
pktBulkData = kmalloc(pktBulkDataLength, GFP_KERNEL);
- memset(pktBulkData, 0, pktBulkDataLength);
} else {
unifi_error(priv, "uf_send_pkt_to_encrypt() : invalid buffer\n");
return;
--
1.7.10.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-12-04 20:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-04 20:41 [PATCH] staging: csr: remove unneeded call to memset() Cyril Roelandt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®