mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Thierry Reding <thierry.reding@avionic-design.de>
Cc: <linux-kernel@vger.kernel.org>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <linux-leds@vger.kernel.org>
Subject: [PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it
Date: Mon, 10 Dec 2012 11:00:36 +0100	[thread overview]
Message-ID: <1355133637-2784-4-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1355133637-2784-1-git-send-email-peter.ujfalusi@ti.com>

Allow client driver to use of_pwm_request() to get the pwm they need. This
is needed for drivers which handle more than one pwm separately, like
leds-pwm driver which have:

pwmleds {
	compatible = "pwm-leds";
	kpad {
		label = "omap4::keypad";
		pwms = <&twl_pwm 0 7812500>;
		max-brightness = <127>;
	};

	charging {
		label = "omap4:green:chrg";
		pwms = <&twl_pwmled 0 7812500>;
		max-brightness = <255>;
	};
};

in the dts files.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
 drivers/pwm/core.c  | 2 +-
 include/linux/pwm.h | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 903138b..3a7ebcc 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -486,7 +486,7 @@ static struct pwm_chip *of_node_to_pwmchip(struct device_node *np)
  * becomes mandatory for devices that look up the PWM device via the con_id
  * parameter.
  */
-static struct pwm_device *of_pwm_request(struct device_node *np,
+struct pwm_device *of_pwm_request(struct device_node *np,
 					 const char *con_id)
 {
 	struct pwm_device *pwm = NULL;
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 6d661f3..d70ffe3 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -175,6 +175,7 @@ struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *pc,
 		const struct of_phandle_args *args);
 
 struct pwm_device *pwm_get(struct device *dev, const char *consumer);
+struct pwm_device *of_pwm_request(struct device_node *np, const char *con_id);
 void pwm_put(struct pwm_device *pwm);
 
 struct pwm_device *devm_pwm_get(struct device *dev, const char *consumer);
@@ -213,6 +214,12 @@ static inline struct pwm_device *pwm_get(struct device *dev,
 	return ERR_PTR(-ENODEV);
 }
 
+static inline struct pwm_device *of_pwm_request(struct device_node *np,
+						const char *con_id)
+{
+	return ERR_PTR(-ENODEV);
+}
+
 static inline void pwm_put(struct pwm_device *pwm)
 {
 }
-- 
1.8.0


  parent reply	other threads:[~2012-12-10 10:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10 10:00 [PATCH v3 0/4] leds: leds-pwm: Device tree support Peter Ujfalusi
2012-12-10 10:00 ` [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm Peter Ujfalusi
2012-12-11  7:03   ` Thierry Reding
     [not found]     ` <3193669.Hv54bBklsP@barack>
2012-12-11  8:36       ` Thierry Reding
     [not found]         ` <1406670.ryvqfkiNXS@barack>
2012-12-11  9:31           ` Thierry Reding
2012-12-11  9:39             ` Peter Ujfalusi
2012-12-11  9:48               ` Thierry Reding
2012-12-11  9:53                 ` Peter Ujfalusi
2012-12-11 10:00                   ` Thierry Reding
2012-12-10 10:00 ` [PATCH v3 2/4] leds: leds-pwm: Preparing the driver for device tree support Peter Ujfalusi
2012-12-11  7:12   ` Thierry Reding
2012-12-10 10:00 ` Peter Ujfalusi [this message]
2012-12-10 23:22   ` [PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it Grant Likely
2012-12-11  7:00   ` Thierry Reding
2012-12-10 10:00 ` [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings Peter Ujfalusi
2012-12-10 23:23   ` Grant Likely
2012-12-11  7:25   ` Thierry Reding
2012-12-12  9:00     ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355133637-2784-4-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=cooloney@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    --cc=thierry.reding@avionic-design.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®