From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Grant Likely <grant.likely@secretlab.ca>,
<linux-kernel@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-leds@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm
Date: Tue, 11 Dec 2012 10:53:11 +0100 [thread overview]
Message-ID: <50C70287.1060006@ti.com> (raw)
In-Reply-To: <20121211094812.GA22222@avionic-0098.adnet.avionic-design.de>
On 12/11/2012 10:48 AM, Thierry Reding wrote:
> On Tue, Dec 11, 2012 at 10:39:53AM +0100, Peter Ujfalusi wrote:
>> On 12/11/2012 10:31 AM, Thierry Reding wrote:
>>> On Tue, Dec 11, 2012 at 09:57:51AM +0100, Peter Ujfalusi wrote:
>>> Okay, if there are no intree users that may be broken, then it should be
>>> fine to remove it. In that case you might want to remove the pwm_id
>>> field as well instead of deprecating it in this patch.
>>
>> The reason I marked the pwm_id as deprecated is to signal to out of tree users
>> (if any) that they should stop using it since it is going to go away in the
>> next cycle.
>> If we remove it right away the sdp4030 board file will not going to compile in
>> subsystem trees, only in linux-next.
>
> Okay, go ahead then. As long as the field will be removed eventually
> that's fine with me.
Thank you and yes, it will be removed.
Probably it would be a good thing to check other places for legacy
pwm_request() users and prepare them to move to (devm_)pwm_get gracefully over
coming kernel releases.
--
Péter
next prev parent reply other threads:[~2012-12-11 9:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 10:00 [PATCH v3 0/4] leds: leds-pwm: Device tree support Peter Ujfalusi
2012-12-10 10:00 ` [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm Peter Ujfalusi
2012-12-11 7:03 ` Thierry Reding
[not found] ` <3193669.Hv54bBklsP@barack>
2012-12-11 8:36 ` Thierry Reding
[not found] ` <1406670.ryvqfkiNXS@barack>
2012-12-11 9:31 ` Thierry Reding
2012-12-11 9:39 ` Peter Ujfalusi
2012-12-11 9:48 ` Thierry Reding
2012-12-11 9:53 ` Peter Ujfalusi [this message]
2012-12-11 10:00 ` Thierry Reding
2012-12-10 10:00 ` [PATCH v3 2/4] leds: leds-pwm: Preparing the driver for device tree support Peter Ujfalusi
2012-12-11 7:12 ` Thierry Reding
2012-12-10 10:00 ` [PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it Peter Ujfalusi
2012-12-10 23:22 ` Grant Likely
2012-12-11 7:00 ` Thierry Reding
2012-12-10 10:00 ` [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings Peter Ujfalusi
2012-12-10 23:23 ` Grant Likely
2012-12-11 7:25 ` Thierry Reding
2012-12-12 9:00 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C70287.1060006@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=cooloney@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome