* [PATCH] dw_dmac: remove redundant check
@ 2012-12-14 9:39 Andy Shevchenko
2012-12-14 11:46 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2012-12-14 9:39 UTC (permalink / raw)
To: Vinod Koul, spear-devel, linux-kernel, Viresh Kumar; +Cc: Andy Shevchenko
There is no need to check the callback_required parameter, due to we check the
callback pointer to be a non-NULL.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/dma/dw_dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 92f33af..3c8acfa 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -364,7 +364,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
spin_unlock_irqrestore(&dwc->lock, flags);
- if (callback_required && callback)
+ if (callback)
callback(param);
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dw_dmac: remove redundant check
2012-12-14 9:39 [PATCH] dw_dmac: remove redundant check Andy Shevchenko
@ 2012-12-14 11:46 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2012-12-14 11:46 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Vinod Koul, spear-devel, linux-kernel
On 14 December 2012 15:09, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There is no need to check the callback_required parameter, due to we check the
> callback pointer to be a non-NULL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/dma/dw_dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 92f33af..3c8acfa 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -364,7 +364,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc,
>
> spin_unlock_irqrestore(&dwc->lock, flags);
>
> - if (callback_required && callback)
> + if (callback)
> callback(param);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-14 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-14 9:39 [PATCH] dw_dmac: remove redundant check Andy Shevchenko
2012-12-14 11:46 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome