Re: [PATCH] scripts: add checkmaintainers.py

[Joe Perches <joe@perches.com>]

On Mon, 2012-12-17 at 11:27 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 11:14:24AM +0100, Michal Marek wrote:
> > On 14.12.2012 23:19, Cesar Eduardo Barros wrote:
> > > This small script checks the file patterns in the MAINTAINERS file.
> > > 
> > > For every file pattern, it checks if the pattern matches any file or
> > > directory in the kernel tree, printing the patterns which do not have a
> > > match.
> > 
> > Can't this be added as a warning to scripts/get_maintainer.pl instead?
> 
> Yep, it definitely makes more sense than having a standalone script.

I'm not so sure of that myself.

I think maybe it should go into checkpatch.

I do have a similar script as a get_maintainers variant.

Adding a --verify-patterns option seems off-topic to
the generic tool use of get_maintainers.

There's a fair amount of tedium for people to do more
than determine there is a pattern that doesn't match
files in git.

Doing the work that Cesar did to find the commit that
makes a pattern valid/invalid when renames or deletions
occur is the chore that could be automated.

Perhaps Cesar can use his script as a starting point
to find those pattern invalidating commits or maybe
add the capability (or a --strict check) to checkpatch.