Re: [PATCH] scripts: add checkmaintainers.py

[Borislav Petkov <bp@alien8.de>]

On Tue, Dec 18, 2012 at 12:36:37PM -0800, Joe Perches wrote:
> You renamed README which is one of the filenames used
> when checkpatch verifies the top-level dir kernel tree.
> 
> Don't do that, README is a required filename.

$ git mv scripts/checkpatch{,-2}.pl
$ git diff --cached HEAD -- | ./scripts/checkpatch-2.pl --strict -
ERROR: Does not appear to be a unified-diff format patch

total: 1 errors, 0 warnings, 0 checks, 0 lines checked

Your patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

 [ adjust .git/hooks/pre-commit to use the new ./scripts/checkpatch-2.pl script
   name]

$ git commit -a
scripts/checkpatch-2.pl:2685: space before tab in indent.
+                                               $ok = 1;
scripts/checkpatch-2.pl:2691: space before tab in indent.
+                                               $ok = 1;

No joy :(

Let's try another file:

$ git mv arch/x86/Kconfig{,.old}
$ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
ERROR: Does not appear to be a unified-diff format patch

total: 1 errors, 0 warnings, 0 checks, 0 lines checked

Your patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

$ git commit -a
arch/x86/Kconfig.old:451: trailing whitespace.
+         Internet Device(MID) platform.

Oh well, enough games for today.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--