* [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
@ 2012-12-18 23:01 Stephen Boyd
2012-12-19 0:23 ` Jesper Juhl
2012-12-20 9:40 ` Bob Liu
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2012-12-18 23:01 UTC (permalink / raw)
To: Bob Liu
Cc: linux-kernel, uclinux-dist-devel, linux-arm-msm, Steven Miao, trivial
It seems that this assignment is done twice in a row. Remove the
duplicate assignment.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: Steven Miao <realmz6@gmail.com>
Cc: trivial@kernel.org
---
Noticed while grepping for broadcast users.
arch/blackfin/kernel/time-ts.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
index f608f02..cb0a484 100644
--- a/arch/blackfin/kernel/time-ts.c
+++ b/arch/blackfin/kernel/time-ts.c
@@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
evt->broadcast = smp_timer_broadcast;
#endif
-
-#ifdef CONFIG_SMP
- evt->broadcast = smp_timer_broadcast;
-#endif
-
-
evt->name = "bfin_core_timer";
evt->rating = 350;
evt->irq = -1;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
@ 2012-12-19 0:23 ` Jesper Juhl
2012-12-20 9:40 ` Bob Liu
1 sibling, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2012-12-19 0:23 UTC (permalink / raw)
To: Stephen Boyd
Cc: Bob Liu, linux-kernel, uclinux-dist-devel, linux-arm-msm,
Steven Miao, trivial
On Tue, 18 Dec 2012, Stephen Boyd wrote:
> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: trivial@kernel.org
> ---
>
> Noticed while grepping for broadcast users.
>
> arch/blackfin/kernel/time-ts.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> evt->broadcast = smp_timer_broadcast;
> #endif
>
> -
> -#ifdef CONFIG_SMP
> - evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
> evt->name = "bfin_core_timer";
> evt->rating = 350;
> evt->irq = -1;
>
Looks good to me.
Feel free to add
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
if you like.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
2012-12-19 0:23 ` Jesper Juhl
@ 2012-12-20 9:40 ` Bob Liu
1 sibling, 0 replies; 3+ messages in thread
From: Bob Liu @ 2012-12-20 9:40 UTC (permalink / raw)
To: Stephen Boyd
Cc: linux-kernel, uclinux-dist-devel, linux-arm-msm, Steven Miao,
trivial, jj
On Wed, Dec 19, 2012 at 7:01 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> It seems that this assignment is done twice in a row. Remove the
> duplicate assignment.
>
That's right.
Will be applied, thanks.
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Cc: Steven Miao <realmz6@gmail.com>
> Cc: trivial@kernel.org
> ---
>
> Noticed while grepping for broadcast users.
>
> arch/blackfin/kernel/time-ts.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/blackfin/kernel/time-ts.c b/arch/blackfin/kernel/time-ts.c
> index f608f02..cb0a484 100644
> --- a/arch/blackfin/kernel/time-ts.c
> +++ b/arch/blackfin/kernel/time-ts.c
> @@ -329,12 +329,6 @@ void bfin_coretmr_clockevent_init(void)
> evt->broadcast = smp_timer_broadcast;
> #endif
>
> -
> -#ifdef CONFIG_SMP
> - evt->broadcast = smp_timer_broadcast;
> -#endif
> -
> -
> evt->name = "bfin_core_timer";
> evt->rating = 350;
> evt->irq = -1;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
--
Regards,
--Bob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-20 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-18 23:01 [PATCH/TRIVIAL] blackfin: time-ts: Remove duplicate assignment Stephen Boyd
2012-12-19 0:23 ` Jesper Juhl
2012-12-20 9:40 ` Bob Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®