mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Fenghua Yu" <fenghua.yu@intel.com>
To: "H Peter Anvin" <hpa@zytor.com>, "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Asit K Mallick" <asit.k.mallick@intel.com>,
	"Tigran Aivazian" <tigran@aivazian.fsnet.co.uk>,
	"Yinghai Lu" <yinghai@kernel.org>,
	"Andreas Herrmann" <andreas.herrmann3@amd.com>,
	"Borislav Petkov" <borislav.petkov@amd.com>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"x86" <x86@kernel.org>
Cc: "Fenghua Yu" <fenghua.yu@intel.com>
Subject: [PATCH v4 03/11] x86/common.c: Make have_cpuid_p() a global function and load ucode or show ucode loading info on AP
Date: Thu, 20 Dec 2012 11:48:05 -0800	[thread overview]
Message-ID: <1356032893-2730-4-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1356032893-2730-1-git-send-email-fenghua.yu@intel.com>

From: Fenghua Yu <fenghua.yu@intel.com>

Remove static declaration in have_cpuid_p() to make it a global function. The
function will be called in early loading microcode.

In 64 bit, load ucode on AP in cpu_init(). In 32 bit, show ucode loading info
on AP in cpu_init().

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
 arch/x86/include/asm/processor.h |  8 ++++++++
 arch/x86/kernel/cpu/common.c     | 17 +++++++++++------
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
index 888184b..3d722fd 100644
--- a/arch/x86/include/asm/processor.h
+++ b/arch/x86/include/asm/processor.h
@@ -190,6 +190,14 @@ extern void init_amd_cacheinfo(struct cpuinfo_x86 *c);
 extern void detect_extended_topology(struct cpuinfo_x86 *c);
 extern void detect_ht(struct cpuinfo_x86 *c);
 
+#ifdef CONFIG_X86_32
+extern int have_cpuid_p(void);
+#else
+static inline int have_cpuid_p(void)
+{
+	return 1;
+}
+#endif
 static inline void native_cpuid(unsigned int *eax, unsigned int *ebx,
 				unsigned int *ecx, unsigned int *edx)
 {
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 9c3ab43..d814772 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -37,6 +37,8 @@
 #include <asm/mce.h>
 #include <asm/msr.h>
 #include <asm/pat.h>
+#include <asm/microcode.h>
+#include <asm/microcode_intel.h>
 
 #ifdef CONFIG_X86_LOCAL_APIC
 #include <asm/uv/uv.h>
@@ -213,7 +215,7 @@ static inline int flag_is_changeable_p(u32 flag)
 }
 
 /* Probe for the CPUID instruction */
-static int __cpuinit have_cpuid_p(void)
+int __cpuinit have_cpuid_p(void)
 {
 	return flag_is_changeable_p(X86_EFLAGS_ID);
 }
@@ -249,11 +251,6 @@ static inline int flag_is_changeable_p(u32 flag)
 {
 	return 1;
 }
-/* Probe for the CPUID instruction */
-static inline int have_cpuid_p(void)
-{
-	return 1;
-}
 static inline void squash_the_stupid_serial_number(struct cpuinfo_x86 *c)
 {
 }
@@ -1223,6 +1220,12 @@ void __cpuinit cpu_init(void)
 	int cpu;
 	int i;
 
+	/*
+	 * Load microcode on this cpu if a valid microcode is available.
+	 * This is early microcode loading procedure.
+	 */
+	load_ucode_ap();
+
 	cpu = stack_smp_processor_id();
 	t = &per_cpu(init_tss, cpu);
 	oist = &per_cpu(orig_ist, cpu);
@@ -1314,6 +1317,8 @@ void __cpuinit cpu_init(void)
 	struct tss_struct *t = &per_cpu(init_tss, cpu);
 	struct thread_struct *thread = &curr->thread;
 
+	show_ucode_info_early();
+
 	if (cpumask_test_and_set_cpu(cpu, cpu_initialized_mask)) {
 		printk(KERN_WARNING "CPU#%d already initialized!\n", cpu);
 		for (;;)
-- 
1.8.0.1


  parent reply	other threads:[~2012-12-21  2:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 19:48 [PATCH v4 00/11] x86/microcode: Early load microcode Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 01/11] Documentation/x86: " Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 02/11] x86/microcode_intel.h: Define functions and macros for early loading ucode Fenghua Yu
2012-12-20 19:48 ` Fenghua Yu [this message]
2012-12-20 19:48 ` [PATCH v4 04/11] x86/microcode_core_early.c: Define interfaces " Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 05/11] x86/microcode_intel_lib.c: Early update ucode on Intel's CPU Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 06/11] x86/tlbflush.h: Define __native_flush_tlb_global_irq_disabled() Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 07/11] x86/microcode_intel_early.c: Early update ucode on Intel's CPU Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 08/11] x86/head_32.S: Early update ucode in 32-bit Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit Fenghua Yu
2012-12-21  4:09   ` Yinghai Lu
2012-12-21  4:44     ` Yu, Fenghua
2012-12-21  5:07     ` Yu, Fenghua
     [not found]       ` <CAE9FiQVHuNkT3BLUW3hJf6mWbNq+kWmohwSNJMxxO1sYvyCxOQ@mail.gmail.com>
2012-12-21  5:48         ` H. Peter Anvin
2012-12-20 19:48 ` [PATCH v4 10/11] x86/mm/init.c: Copy ucode from initrd image to kernel memory Fenghua Yu
2012-12-20 19:48 ` [PATCH v4 11/11] x86/Kconfig: Configurations to enable/disable the feature Fenghua Yu
2012-12-21  9:04 ` [PATCH v4 00/11] x86/microcode: Early load microcode Michael Tokarev
2012-12-21 15:09   ` Yu, Fenghua
2012-12-21 15:14     ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356032893-2730-4-git-send-email-fenghua.yu@intel.com \
    --to=fenghua.yu@intel.com \
    --cc=andreas.herrmann3@amd.com \
    --cc=asit.k.mallick@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tigran@aivazian.fsnet.co.uk \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®