mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/3] staging: android: Minor changes - again.
@ 2012-12-21 23:00 Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 1/3] staging: android: Avoid using camelcase in binder.h Cruz Julian Bishop
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Cruz Julian Bishop @ 2012-12-21 23:00 UTC (permalink / raw)
  To: greg; +Cc: swetland, linux-kernel, Cruz Julian Bishop

Hi, Greg and others.

This is a small patch series to fix some checkpatch issues and add
some help documentation to Kconfig.

Sorry if I messed up - I haven't written Kconfig documentation before,
so I'm not quite sure if it has to be in a certain style.

Cruz Julian Bishop (3):
  staging: android: Avoid using camelcase in binder.h
  staging: android: Fix two checkpatch issues in binder.c
  staging: android: Add some Kconfig help entries

 drivers/staging/android/Kconfig  |   29 ++++++++++++++++++++++++++---
 drivers/staging/android/binder.c |    6 +++---
 drivers/staging/android/binder.h |    4 ++--
 3 files changed, 31 insertions(+), 8 deletions(-)

-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] staging: android: Avoid using camelcase in binder.h
  2012-12-21 23:00 [PATCH 0/3] staging: android: Minor changes - again Cruz Julian Bishop
@ 2012-12-21 23:00 ` Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 2/3] staging: android: Fix two checkpatch issues in binder.c Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 3/3] staging: android: Add some Kconfig help entries Cruz Julian Bishop
  2 siblings, 0 replies; 4+ messages in thread
From: Cruz Julian Bishop @ 2012-12-21 23:00 UTC (permalink / raw)
  To: greg; +Cc: swetland, linux-kernel, Cruz Julian Bishop

This changes the following:

1: BinderDriverReturnProtocol -> binder_driver_return_protocol
2: BinderDriverCommandProtocol -> binder_driver_return_protocol

These enums are not currently used, but still generate noise in checkpatch.

Well, did. They don't now :)

Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
---
 drivers/staging/android/binder.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
index 2f7d195..76ead8d 100644
--- a/drivers/staging/android/binder.h
+++ b/drivers/staging/android/binder.h
@@ -163,7 +163,7 @@ struct binder_pri_ptr_cookie {
 	void *cookie;
 };
 
-enum BinderDriverReturnProtocol {
+enum binder_driver_return_protocol {
 	BR_ERROR = _IOR('r', 0, int),
 	/*
 	 * int: error code
@@ -251,7 +251,7 @@ enum BinderDriverReturnProtocol {
 	 */
 };
 
-enum BinderDriverCommandProtocol {
+enum binder_driver_command_protocol {
 	BC_TRANSACTION = _IOW('c', 0, struct binder_transaction_data),
 	BC_REPLY = _IOW('c', 1, struct binder_transaction_data),
 	/*
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/3] staging: android: Fix two checkpatch issues in binder.c
  2012-12-21 23:00 [PATCH 0/3] staging: android: Minor changes - again Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 1/3] staging: android: Avoid using camelcase in binder.h Cruz Julian Bishop
@ 2012-12-21 23:00 ` Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 3/3] staging: android: Add some Kconfig help entries Cruz Julian Bishop
  2 siblings, 0 replies; 4+ messages in thread
From: Cruz Julian Bishop @ 2012-12-21 23:00 UTC (permalink / raw)
  To: greg; +Cc: swetland, linux-kernel, Cruz Julian Bishop

This fixes two instances of
"static const char * array should probably be static const char * const"

I have seen other commits doing this in other files, so I am
assuming it should be done here as well.

Please tell me if this is wrong :)

Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
---
 drivers/staging/android/binder.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index 2d12e8a..538ebe2 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -3227,7 +3227,7 @@ static void print_binder_proc(struct seq_file *m,
 		m->count = start_pos;
 }
 
-static const char *binder_return_strings[] = {
+static const char * const binder_return_strings[] = {
 	"BR_ERROR",
 	"BR_OK",
 	"BR_TRANSACTION",
@@ -3248,7 +3248,7 @@ static const char *binder_return_strings[] = {
 	"BR_FAILED_REPLY"
 };
 
-static const char *binder_command_strings[] = {
+static const char * const binder_command_strings[] = {
 	"BC_TRANSACTION",
 	"BC_REPLY",
 	"BC_ACQUIRE_RESULT",
@@ -3268,7 +3268,7 @@ static const char *binder_command_strings[] = {
 	"BC_DEAD_BINDER_DONE"
 };
 
-static const char *binder_objstat_strings[] = {
+static const char * const binder_objstat_strings[] = {
 	"proc",
 	"thread",
 	"node",
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/3] staging: android: Add some Kconfig help entries
  2012-12-21 23:00 [PATCH 0/3] staging: android: Minor changes - again Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 1/3] staging: android: Avoid using camelcase in binder.h Cruz Julian Bishop
  2012-12-21 23:00 ` [PATCH 2/3] staging: android: Fix two checkpatch issues in binder.c Cruz Julian Bishop
@ 2012-12-21 23:00 ` Cruz Julian Bishop
  2 siblings, 0 replies; 4+ messages in thread
From: Cruz Julian Bishop @ 2012-12-21 23:00 UTC (permalink / raw)
  To: greg; +Cc: swetland, linux-kernel, Cruz Julian Bishop

This commit adds Kconfig entries for the following:

	1: ANDROID_BINDER_IPC
	2: ASHMEM (additional text)
	3: ANDROID_LOGGER

It also changes "Register" to "Registers" in
ANDROID_LOW_MEMORY_KILLER

Finally, all "help" instances are changed to "---help---",
as recommended by kconfig-language.txt in order to visually
aid developers.

Signed-off-by: Cruz Julian Bishop <cruzjbishop@gmail.com>
---
 drivers/staging/android/Kconfig |   29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
index 0ce50d1..465a28c 100644
--- a/drivers/staging/android/Kconfig
+++ b/drivers/staging/android/Kconfig
@@ -11,19 +11,42 @@ if ANDROID
 config ANDROID_BINDER_IPC
 	bool "Android Binder IPC Driver"
 	default n
+	---help---
+	  Binder is used in Android for both communication between processes,
+	  and remote method invocation.
+
+	  This means one Android process can call a method/routine in another
+	  Android process, using Binder to identify, invoke and pass arguments
+	  between said processes.
 
 config ASHMEM
 	bool "Enable the Anonymous Shared Memory Subsystem"
 	default n
 	depends on SHMEM || TINY_SHMEM
-	help
+	---help---
 	  The ashmem subsystem is a new shared memory allocator, similar to
 	  POSIX SHM but with different behavior and sporting a simpler
 	  file-based API.
 
+	  It is, in theory, a good memory allocator for low-memory devices,
+	  because it can discard shared memory units when under memory pressure.
+
 config ANDROID_LOGGER
 	tristate "Android log driver"
 	default n
+	---help---
+	  This adds support for system-wide logging using four log buffers.
+
+	  These are:
+
+	      1: main
+	      2: events
+	      3: radio
+	      4: system
+
+	  Log reading and writing is performed via normal Linux reads and
+	  optimized writes. This optimization avoids logging having too
+	  much overhead in the system.
 
 config ANDROID_TIMED_OUTPUT
 	bool "Timed output class driver"
@@ -38,13 +61,13 @@ config ANDROID_LOW_MEMORY_KILLER
 	bool "Android Low Memory Killer"
 	default N
 	---help---
-	  Register processes to be killed when memory is low
+	  Registers processes to be killed when memory is low
 
 config ANDROID_INTF_ALARM_DEV
 	bool "Android alarm driver"
 	depends on RTC_CLASS
 	default n
-	help
+	---help---
 	  Provides non-wakeup and rtc backed wakeup alarms based on rtc or
 	  elapsed realtime, and a non-wakeup alarm on the monotonic clock.
 	  Also exports the alarm interface to user-space.
-- 
1.7.10.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-12-21 23:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-21 23:00 [PATCH 0/3] staging: android: Minor changes - again Cruz Julian Bishop
2012-12-21 23:00 ` [PATCH 1/3] staging: android: Avoid using camelcase in binder.h Cruz Julian Bishop
2012-12-21 23:00 ` [PATCH 2/3] staging: android: Fix two checkpatch issues in binder.c Cruz Julian Bishop
2012-12-21 23:00 ` [PATCH 3/3] staging: android: Add some Kconfig help entries Cruz Julian Bishop

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®