From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>
Subject: [PATCH 09/10] mfd: twl-core: Remove no longer valid comment regarding to write buffer size
Date: Mon, 31 Dec 2012 12:09:30 +0100 [thread overview]
Message-ID: <1356952171-6109-10-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1356952171-6109-1-git-send-email-peter.ujfalusi@ti.com>
With the regmap conversion there is no longeer a need to allocate bigger
buffer for writes
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/twl-core.c | 3 ---
include/linux/i2c/twl.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index e2895a4..9661204 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -308,9 +308,6 @@ EXPORT_SYMBOL(twl_rev);
* @reg: register address (just offset will do)
* @num_bytes: number of bytes to transfer
*
- * IMPORTANT: for 'value' parameter: Allocate value num_bytes+1 and
- * valid data starts at Offset 1.
- *
* Returns the result of operation - 0 is success
*/
int twl_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes)
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index 72adc88..e441fd8 100644
--- a/include/linux/i2c/twl.h
+++ b/include/linux/i2c/twl.h
@@ -182,9 +182,6 @@ int twl_i2c_read_u8(u8 mod_no, u8 *val, u8 reg);
/*
* Read and write several 8-bit registers at once.
- *
- * IMPORTANT: For twl_i2c_write(), allocate num_bytes + 1
- * for the value, and populate your data starting at offset 1.
*/
int twl_i2c_write(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
int twl_i2c_read(u8 mod_no, u8 *value, u8 reg, unsigned num_bytes);
--
1.8.0.2
next prev parent reply other threads:[~2012-12-31 11:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 11:09 [PATCH 00/10] MFD: twl-core: Cleanup part 2 for 3.9 Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 01/10] mfd: twl-core: Clean up module id lookup and definitions Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 02/10] mfd: twl-core: No need to check for invalid subchip ID Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 03/10] mfd: twl-core: Use the lookup table to find the correct subchip for the modules Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 04/10] mfd: twl-core: Allocate twl_modules dynamically Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 05/10] mfd: twl-core: Do not try to call legacy mfd add_children() when booted with DT Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 06/10] mfd: twl-core: Do not create dummy pdata " Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 07/10] mfd: twl-core: Move 'inuse' check early at probe time Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 08/10] mfd: twl-core: Collect global variables behind one private structure (global) Peter Ujfalusi
2012-12-31 11:09 ` Peter Ujfalusi [this message]
2012-12-31 11:09 ` [PATCH 10/10] mfd: twl-core: Move twl_i2c_read/write_u8 to header as inline function Peter Ujfalusi
2013-01-15 8:20 ` [PATCH 00/10] MFD: twl-core: Cleanup part 2 for 3.9 Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356952171-6109-10-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®