From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>
Subject: [PATCH 07/10] mfd: twl-core: Move 'inuse' check early at probe time
Date: Mon, 31 Dec 2012 12:09:28 +0100 [thread overview]
Message-ID: <1356952171-6109-8-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1356952171-6109-1-git-send-email-peter.ujfalusi@ti.com>
We can fail earlier in case multiple instance of the twl-core is tried to
be loaded.
The twl-core by design only supports one instance.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/mfd/twl-core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 547fed5..1827088 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -1170,6 +1170,12 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
return -EINVAL;
}
+ if (inuse) {
+ dev_dbg(&client->dev, "only one instance of %s allowed\n",
+ DRIVER_NAME);
+ return -EBUSY;
+ }
+
pdev = platform_device_alloc(DRIVER_NAME, -1);
if (!pdev) {
dev_err(&client->dev, "can't alloc pdev\n");
@@ -1188,12 +1194,6 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
goto free;
}
- if (inuse) {
- dev_dbg(&client->dev, "driver is already in use\n");
- status = -EBUSY;
- goto free;
- }
-
if ((id->driver_data) & TWL6030_CLASS) {
twl_id = TWL6030_CLASS_ID;
twl_map = &twl6030_map[0];
--
1.8.0.2
next prev parent reply other threads:[~2012-12-31 11:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 11:09 [PATCH 00/10] MFD: twl-core: Cleanup part 2 for 3.9 Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 01/10] mfd: twl-core: Clean up module id lookup and definitions Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 02/10] mfd: twl-core: No need to check for invalid subchip ID Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 03/10] mfd: twl-core: Use the lookup table to find the correct subchip for the modules Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 04/10] mfd: twl-core: Allocate twl_modules dynamically Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 05/10] mfd: twl-core: Do not try to call legacy mfd add_children() when booted with DT Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 06/10] mfd: twl-core: Do not create dummy pdata " Peter Ujfalusi
2012-12-31 11:09 ` Peter Ujfalusi [this message]
2012-12-31 11:09 ` [PATCH 08/10] mfd: twl-core: Collect global variables behind one private structure (global) Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 09/10] mfd: twl-core: Remove no longer valid comment regarding to write buffer size Peter Ujfalusi
2012-12-31 11:09 ` [PATCH 10/10] mfd: twl-core: Move twl_i2c_read/write_u8 to header as inline function Peter Ujfalusi
2013-01-15 8:20 ` [PATCH 00/10] MFD: twl-core: Cleanup part 2 for 3.9 Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356952171-6109-8-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®