From: Matt Fleming <matt@console-pimps.org>
To: Steve Langasek <steve.langasek@canonical.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>, Olof Johansson <olof@lixom.net>,
Tony Luck <tony.luck@intel.com>,
Matt Fleming <matt.fleming@intel.com>,
Corentin Chary <corentincj@iksaif.net>,
platform-driver-x86@vger.kernel.org
Subject: [RFC PATCH 2/2] samsung-laptop: Disable on EFI hardware
Date: Thu, 3 Jan 2013 13:18:05 +0000 [thread overview]
Message-ID: <1357219085-4312-3-git-send-email-matt@console-pimps.org> (raw)
In-Reply-To: <1357219085-4312-1-git-send-email-matt@console-pimps.org>
From: Matt Fleming <matt.fleming@intel.com>
There have been reports of this driver causing Machine Check
Exceptions on recent EFI-enabled Samsung laptops,
https://bugzilla.kernel.org/show_bug.cgi?id=47121
So disable it if booting from EFI since this driver relies on
grovelling around in the BIOS memory map which isn't going to work.
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Steve Langasek <steve.langasek@canonical.com>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---
drivers/platform/x86/samsung-laptop.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index dd90d15..a94c0ee 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1534,6 +1534,9 @@ static int __init samsung_init(void)
struct samsung_laptop *samsung;
int ret;
+ if (efi_enabled(EFI_BOOT))
+ return -ENODEV;
+
quirks = &samsung_unknown;
if (!force && !dmi_check_system(samsung_dmi_table))
return -ENODEV;
--
1.7.11.7
prev parent reply other threads:[~2013-01-03 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 13:18 [RFC PATCH 0/2] EFI facilities bitfield Matt Fleming
2013-01-03 13:18 ` [RFC PATCH 1/2] efi: Make 'efi_enabled' a function to query EFI facilities Matt Fleming
2013-01-03 17:41 ` H. Peter Anvin
2013-01-04 15:08 ` Tim Gardner
2013-01-04 16:15 ` Matt Fleming
2013-01-04 16:17 ` H. Peter Anvin
2013-01-04 16:42 ` Tim Gardner
2013-01-03 13:18 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357219085-4312-3-git-send-email-matt@console-pimps.org \
--to=matt@console-pimps.org \
--cc=corentincj@iksaif.net \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=olof@lixom.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=steve.langasek@canonical.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®