From: Stephane Eranian <eranian@google.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v5 17/18] perf tools: Ignore ABS symbols when loading data maps
Date: Mon, 7 Jan 2013 19:27:56 +0100 [thread overview]
Message-ID: <1357583277-4553-18-git-send-email-eranian@google.com> (raw)
In-Reply-To: <1357583277-4553-1-git-send-email-eranian@google.com>
From: Namhyung Kim <namhyung.kim@lge.com>
When loading symbols in a data mapping, ABS symbols (which has a value
of SHN_ABS in its st_shndx) failed at elf_getscn(). And it marks the
loading as a failure so already loaded symbols cannot be fixed up.
I'm not sure what should be done. Just ignore them for now. :)
Cc: Stephane Eranian <eranian@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/util/symbol-elf.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
index db0cc92..00cf128 100644
--- a/tools/perf/util/symbol-elf.c
+++ b/tools/perf/util/symbol-elf.c
@@ -719,6 +719,9 @@ int dso__load_sym(struct dso *dso, struct map *map,
used_opd = true;
}
+ if (sym.st_shndx == SHN_ABS)
+ continue;
+
sec = elf_getscn(runtime_ss->elf, sym.st_shndx);
if (!sec)
goto out_elf_end;
--
1.7.9.5
next prev parent reply other threads:[~2013-01-07 18:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 18:27 [PATCH v5 00/18] perf: add memory access sampling support Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 01/18] perf, x86: Support CPU specific sysfs events Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 02/18] perf/x86: improve sysfs event mapping with event string Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 03/18] perf/x86: add flags to event constraints Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 04/18] perf, core: Add a concept of a weightened sample Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 05/18] perf: add minimal support for PERF_SAMPLE_WEIGHT Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 06/18] perf: add support for PERF_SAMPLE_ADDR in dump_sampple() Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 07/18] perf: add generic memory sampling interface Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 08/18] perf/x86: add memory profiling via PEBS Load Latency Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 09/18] perf/x86: export PEBS load latency threshold register to sysfs Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 10/18] perf/x86: add support for PEBS Precise Store Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 11/18] perf tools: add mem access sampling core support Stephane Eranian
2013-01-09 16:55 ` Jiri Olsa
2013-01-10 21:53 ` Stephane Eranian
2013-01-11 13:31 ` Jiri Olsa
2013-01-11 14:08 ` Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 12/18] perf report: add support for mem access profiling Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 13/18] perf record: " Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 14/18] perf tools: add new mem command for memory " Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 15/18] perf: add PERF_RECORD_MISC_MMAP_DATA to RECORD_MMAP Stephane Eranian
2013-01-07 18:27 ` [PATCH v5 16/18] perf tools: detect data vs. text mappings Stephane Eranian
2013-01-07 18:27 ` Stephane Eranian [this message]
2013-01-07 18:27 ` [PATCH v5 18/18] perf tools: Fix output of symbol_daddr offset Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357583277-4553-18-git-send-email-eranian@google.com \
--to=eranian@google.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®