Re: [PATCH v5 11/18] perf tools: add mem access sampling core support

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Jan 10, 2013 at 10:53:26PM +0100, Stephane Eranian wrote:
> On Wed, Jan 9, 2013 at 5:55 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> > On Mon, Jan 07, 2013 at 07:27:50PM +0100, Stephane Eranian wrote:

SNIP

> >
> > The crash I report is due to the some maps could be removed
> > via map_groups__fixup_overlappings.
> >
> > Attached patch makes the code working for me, but we might
> > want to have some global unified fix for that, since this
> > is not the only place suffering for that.
> >
> > Like globaly set map->referenced in add_hist_entry or
> > hist_entry__new functions..
> >
> >
> Would something like that work for you (untested)?

yep, works ok for me (tested)... how about branch_info? looks like 

  branch_info::from
  branch_info::to

need same treatment

thanks,
jirka

> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 7034500..fc05b9f 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -274,6 +274,12 @@ static struct hist_entry *hist_entry__new(struct
> hist_entry *template)
> 
>                 if (he->ms.map)
>                         he->ms.map->referenced = true;
> +               if (he->mem_info) {
> +                       if (he->mem_info->iaddr.map)
> +                               he->mem_info->iaddr.map->referenced = true;
> +                       if (he->mem_info->daddr.map)
> +                               he->mem_info->daddr.map->referenced = true;
> +               }
>                 if (symbol_conf.use_callchain)
>                         callchain_init(he->callchain);