mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: "John Stultz" <john.stultz@linaro.org>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"Serban Constantinescu" <serban.constantinescu@arm.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Colin Cross" <ccross@google.com>,
	"Android Kernel Team" <kernel-team@android.com>
Subject: [RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctl support (v2)
Date: Fri, 11 Jan 2013 15:46:21 -0800	[thread overview]
Message-ID: <1357947984-15611-1-git-send-email-john.stultz@linaro.org> (raw)

Here is the second revision at implementing compat_ioctl support for
Android's alarm-dev driver in staging.

The first patch removes the pre-Android 1.0 _OLD ioctls, per Colin's
suggestion. Then the second patch does some refactoring to cleanup
and separate the copying of user data from the logic, and the final
patch adds the compat_ioctl support.

I've tested this with a trivial unit test compiled for both 32bit
and 64bit on a x86_64 kernel, and it looks ok, but closer review
would be appreciated to make sure I didn't break anything.

Additional feedback or thoughts would be welcome!

thanks
-john

Cc: Greg KH <gregkh@linuxfoundation.org>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Colin Cross <ccross@google.com>
Cc: Android Kernel Team <kernel-team@android.com>

John Stultz (3):
  staging: alarm-dev: Drop pre Android 1.0 _OLD ioctls
  staging: alarm-dev: Refactor alarm-dev ioctl code in prep for
    compat_ioctl
  staging: alarm-dev: Implement compat_ioctl support

 drivers/staging/android/alarm-dev.c     |  277 +++++++++++++++++++------------
 drivers/staging/android/android_alarm.h |   19 +++
 2 files changed, 193 insertions(+), 103 deletions(-)

-- 
1.7.10.4


             reply	other threads:[~2013-01-11 23:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 23:46 John Stultz [this message]
2013-01-11 23:46 ` [RFC][PATCH 1/3] staging: alarm-dev: Drop pre Android 1.0 _OLD ioctls John Stultz
2013-01-11 23:46 ` [RFC][PATCH 2/3] staging: alarm-dev: Refactor alarm-dev ioctl code in prep for compat_ioctl John Stultz
2013-01-11 23:46 ` [RFC][PATCH 3/3] staging: alarm-dev: Implement compat_ioctl support John Stultz
2013-01-18  0:48 ` [RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctl support (v2) Greg KH
2013-01-18  1:09   ` John Stultz
2013-01-18 21:32     ` Arve Hjønnevåg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357947984-15611-1-git-send-email-john.stultz@linaro.org \
    --to=john.stultz@linaro.org \
    --cc=arve@android.com \
    --cc=ccross@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serban.constantinescu@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®