From: Greg KH <gregkh@linuxfoundation.org>
To: John Stultz <john.stultz@linaro.org>
Cc: linux-kernel@vger.kernel.org,
"Serban Constantinescu" <serban.constantinescu@arm.com>,
"Arve Hjønnevåg" <arve@android.com>,
"Colin Cross" <ccross@google.com>,
"Android Kernel Team" <kernel-team@android.com>
Subject: Re: [RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctl support (v2)
Date: Thu, 17 Jan 2013 16:48:27 -0800 [thread overview]
Message-ID: <20130118004827.GB8897@kroah.com> (raw)
In-Reply-To: <1357947984-15611-1-git-send-email-john.stultz@linaro.org>
On Fri, Jan 11, 2013 at 03:46:21PM -0800, John Stultz wrote:
> Here is the second revision at implementing compat_ioctl support for
> Android's alarm-dev driver in staging.
>
> The first patch removes the pre-Android 1.0 _OLD ioctls, per Colin's
> suggestion. Then the second patch does some refactoring to cleanup
> and separate the copying of user data from the logic, and the final
> patch adds the compat_ioctl support.
>
> I've tested this with a trivial unit test compiled for both 32bit
> and 64bit on a x86_64 kernel, and it looks ok, but closer review
> would be appreciated to make sure I didn't break anything.
>
> Additional feedback or thoughts would be welcome!
These look fine to me, want me to apply them to my -next tree for 3.9?
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-18 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 23:46 John Stultz
2013-01-11 23:46 ` [RFC][PATCH 1/3] staging: alarm-dev: Drop pre Android 1.0 _OLD ioctls John Stultz
2013-01-11 23:46 ` [RFC][PATCH 2/3] staging: alarm-dev: Refactor alarm-dev ioctl code in prep for compat_ioctl John Stultz
2013-01-11 23:46 ` [RFC][PATCH 3/3] staging: alarm-dev: Implement compat_ioctl support John Stultz
2013-01-18 0:48 ` Greg KH [this message]
2013-01-18 1:09 ` [RFC][PATCH 0/3] staging: alarm-dev: Cleanups and compat_ioctl support (v2) John Stultz
2013-01-18 21:32 ` Arve Hjønnevåg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118004827.GB8897@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=ccross@google.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®