[PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

With CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:

ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!

Fix this by adding the missing EXPORT_SYMBOL for guest_enter() and
guest_exit() in kernel/context_tracking.c as suggested by Frederic.

This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
add generic guest entry/exit callbacks").

Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 kernel/context_tracking.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index bbb2c2c..950f30a 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -111,14 +111,16 @@ void guest_enter(void)
 	else
 		__guest_enter();
 }
+EXPORT_SYMBOL(guest_enter);
 
 void guest_exit(void)
-{
+{i
 	if (vtime_accounting_enabled())
 		vtime_guest_exit(current);
 	else
 		__guest_exit();
 }
+EXPORT_SYMBOL(guest_exit);
 #endif
 
 
-- 
1.8.1.1

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[devendra.aaru]

On Wed, Jan 23, 2013 at 8:15 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> With CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>
> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>
> Fix this by adding the missing EXPORT_SYMBOL for guest_enter() and
> guest_exit() in kernel/context_tracking.c as suggested by Frederic.
>
> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
> add generic guest entry/exit callbacks").
>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
> ---
>  kernel/context_tracking.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index bbb2c2c..950f30a 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -111,14 +111,16 @@ void guest_enter(void)
>         else
>                 __guest_enter();
>  }
> +EXPORT_SYMBOL(guest_enter);
>
>  void guest_exit(void)
> -{
> +{i

compilation fails with that?


>         if (vtime_accounting_enabled())
>                 vtime_guest_exit(current);
>         else
>                 __guest_exit();
>  }
> +EXPORT_SYMBOL(guest_exit);
>  #endif
>
>
> --
> 1.8.1.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

On Wed, Jan 23, 2013 at 2:17 PM, devendra.aaru <devendra.aaru@gmail.com> wrote:
> On Wed, Jan 23, 2013 at 8:15 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>> With CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>>
>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>
>> Fix this by adding the missing EXPORT_SYMBOL for guest_enter() and
>> guest_exit() in kernel/context_tracking.c as suggested by Frederic.
>>
>> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
>> add generic guest entry/exit callbacks").
>>
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>> ---
>>  kernel/context_tracking.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>> index bbb2c2c..950f30a 100644
>> --- a/kernel/context_tracking.c
>> +++ b/kernel/context_tracking.c
>> @@ -111,14 +111,16 @@ void guest_enter(void)
>>         else
>>                 __guest_enter();
>>  }
>> +EXPORT_SYMBOL(guest_enter);
>>
>>  void guest_exit(void)
>> -{
>> +{i
>
> compilation fails with that?
>

Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!

- Sedat -

>
>>         if (vtime_accounting_enabled())
>>                 vtime_guest_exit(current);
>>         else
>>                 __guest_exit();
>>  }
>> +EXPORT_SYMBOL(guest_exit);
>>  #endif
>>
>>
>> --
>> 1.8.1.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
> On Wed, Jan 23, 2013 at 2:17 PM, devendra.aaru <devendra.aaru@gmail.com> wrote:
>> On Wed, Jan 23, 2013 at 8:15 AM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>> With CONFIG_KVM=m my build with 3.8-rc4-nohz3 breaks like this:
>>>
>>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined!
>>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined!
>>>
>>> Fix this by adding the missing EXPORT_SYMBOL for guest_enter() and
>>> guest_exit() in kernel/context_tracking.c as suggested by Frederic.
>>>
>>> This issue was introduced with commit 8eebafe9be58 ("kvm: Prepare to
>>> add generic guest entry/exit callbacks").
>>>
>>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>>> ---
>>>  kernel/context_tracking.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>>> index bbb2c2c..950f30a 100644
>>> --- a/kernel/context_tracking.c
>>> +++ b/kernel/context_tracking.c
>>> @@ -111,14 +111,16 @@ void guest_enter(void)
>>>         else
>>>                 __guest_enter();
>>>  }
>>> +EXPORT_SYMBOL(guest_enter);
>>>
>>>  void guest_exit(void)
>>> -{
>>> +{i
>>
>> compilation fails with that?
>>
>
> Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!

I believe he pointed out the "{i" to you. Typing mistake?

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Steven Rostedt]

On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:

> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
> 
> I believe he pointed out the "{i" to you. Typing mistake?

In which case the CONFIG_KVM=y is a work around if that {i is within a
#ifndef CONFIG_KVM ;-)

-- Steve

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>
>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>
>> I believe he pointed out the "{i" to you. Typing mistake?
>
> In which case the CONFIG_KVM=y is a work around if that {i is within a
> #ifndef CONFIG_KVM ;-)

No it's in #ifdef CONFIG_KVM so the right fix is:

diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index bbb2c2c..a13b8a3 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -111,14 +111,19 @@ void guest_enter(void)
        else
                __guest_enter();
 }
+EXPORT_SYMBOL_GPL(guest_enter);

 void guest_exit(void)
 {
+#ifndef CONFIG_KVM
+i
+#endif
        if (vtime_accounting_enabled())
                vtime_guest_exit(current);
        else
                __guest_exit();
 }
+EXPORT_SYMBOL_GPL(guest_exit);
 #endif

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

On Wed, Jan 23, 2013 at 3:02 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
>> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>>
>>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>>
>>> I believe he pointed out the "{i" to you. Typing mistake?
>>
>> In which case the CONFIG_KVM=y is a work around if that {i is within a
>> #ifndef CONFIG_KVM ;-)
>
> No it's in #ifdef CONFIG_KVM so the right fix is:
>
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index bbb2c2c..a13b8a3 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -111,14 +111,19 @@ void guest_enter(void)
>         else
>                 __guest_enter();
>  }
> +EXPORT_SYMBOL_GPL(guest_enter);
>
>  void guest_exit(void)
>  {
> +#ifndef CONFIG_KVM
> +i
> +#endif
>         if (vtime_accounting_enabled())
>                 vtime_guest_exit(current);
>         else
>                 __guest_exit();
>  }
> +EXPORT_SYMBOL_GPL(guest_exit);
>  #endif

With and without the magic "i" hack the warning still remains!
Dropped the coffee on my t-shirt, damn Frederic.

- Sedat -

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

On Wed, Jan 23, 2013 at 3:02 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
>> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>>
>>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>>
>>> I believe he pointed out the "{i" to you. Typing mistake?
>>
>> In which case the CONFIG_KVM=y is a work around if that {i is within a
>> #ifndef CONFIG_KVM ;-)
>
> No it's in #ifdef CONFIG_KVM so the right fix is:
>
> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index bbb2c2c..a13b8a3 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -111,14 +111,19 @@ void guest_enter(void)
>         else
>                 __guest_enter();
>  }
> +EXPORT_SYMBOL_GPL(guest_enter);
>
>  void guest_exit(void)
>  {
> +#ifndef CONFIG_KVM
> +i
> +#endif
>         if (vtime_accounting_enabled())
>                 vtime_guest_exit(current);
>         else
>                 __guest_exit();
>  }
> +EXPORT_SYMBOL_GPL(guest_exit);
>  #endif

So, what's the real fix for this issue?

- Sedat -

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
> On Wed, Jan 23, 2013 at 3:02 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
>> 2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
>>> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>>>
>>>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>>>
>>>> I believe he pointed out the "{i" to you. Typing mistake?
>>>
>>> In which case the CONFIG_KVM=y is a work around if that {i is within a
>>> #ifndef CONFIG_KVM ;-)
>>
>> No it's in #ifdef CONFIG_KVM so the right fix is:
>>
>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>> index bbb2c2c..a13b8a3 100644
>> --- a/kernel/context_tracking.c
>> +++ b/kernel/context_tracking.c
>> @@ -111,14 +111,19 @@ void guest_enter(void)
>>         else
>>                 __guest_enter();
>>  }
>> +EXPORT_SYMBOL_GPL(guest_enter);
>>
>>  void guest_exit(void)
>>  {
>> +#ifndef CONFIG_KVM
>> +i
>> +#endif
>>         if (vtime_accounting_enabled())
>>                 vtime_guest_exit(current);
>>         else
>>                 __guest_exit();
>>  }
>> +EXPORT_SYMBOL_GPL(guest_exit);
>>  #endif
>
> So, what's the real fix for this issue?

So CONFIG_SOMETHING doesn't work when it's a module. Hence we need to
remove the ifdef CONFIG_KVM around guest_enter(), guest_exit(),
vtime_guest_enter() and vtime_guest_exit(). Also it seems we need
<linux/export.h> in context_tracking.c

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Steven Rostedt]

On Wed, 2013-01-23 at 15:02 +0100, Frederic Weisbecker wrote:

> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
> index bbb2c2c..a13b8a3 100644
> --- a/kernel/context_tracking.c
> +++ b/kernel/context_tracking.c
> @@ -111,14 +111,19 @@ void guest_enter(void)
>         else
>                 __guest_enter();
>  }
> +EXPORT_SYMBOL_GPL(guest_enter);
> 
>  void guest_exit(void)
>  {
> +#ifndef CONFIG_KVM
> +i
> +#endif

I don't like #ifdefs in .c files. They belong in headers. Could you
convert this to be:

include/linux/context_tracking.h:

#ifdef CONFIG_KVM
 #define add_vi_i_typo()
#else
 #define add_vi_i_typo()	i
#endif

and then in context_tracking.c:

void guest_exit(void)
{
	add_vi_typo();

[...]

-- Steve

>         if (vtime_accounting_enabled())
>                 vtime_guest_exit(current);
>         else
>                 __guest_exit();
>  }
> +EXPORT_SYMBOL_GPL(guest_exit);
>  #endif

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
> On Wed, 2013-01-23 at 15:02 +0100, Frederic Weisbecker wrote:
>
>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>> index bbb2c2c..a13b8a3 100644
>> --- a/kernel/context_tracking.c
>> +++ b/kernel/context_tracking.c
>> @@ -111,14 +111,19 @@ void guest_enter(void)
>>         else
>>                 __guest_enter();
>>  }
>> +EXPORT_SYMBOL_GPL(guest_enter);
>>
>>  void guest_exit(void)
>>  {
>> +#ifndef CONFIG_KVM
>> +i
>> +#endif
>
> I don't like #ifdefs in .c files. They belong in headers. Could you
> convert this to be:
>
> include/linux/context_tracking.h:
>
> #ifdef CONFIG_KVM
>  #define add_vi_i_typo()
> #else
>  #define add_vi_i_typo()        i
> #endif
>
> and then in context_tracking.c:
>
> void guest_exit(void)
> {
>         add_vi_typo();
>
> [...]

Much cleaner indeed! And this way it's more generally available for
further users.

Will do the change, thanks!

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

On Wed, Jan 23, 2013 at 4:03 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
>> On Wed, Jan 23, 2013 at 3:02 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
>>> 2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
>>>> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>>>>
>>>>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>>>>
>>>>> I believe he pointed out the "{i" to you. Typing mistake?
>>>>
>>>> In which case the CONFIG_KVM=y is a work around if that {i is within a
>>>> #ifndef CONFIG_KVM ;-)
>>>
>>> No it's in #ifdef CONFIG_KVM so the right fix is:
>>>
>>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>>> index bbb2c2c..a13b8a3 100644
>>> --- a/kernel/context_tracking.c
>>> +++ b/kernel/context_tracking.c
>>> @@ -111,14 +111,19 @@ void guest_enter(void)
>>>         else
>>>                 __guest_enter();
>>>  }
>>> +EXPORT_SYMBOL_GPL(guest_enter);
>>>
>>>  void guest_exit(void)
>>>  {
>>> +#ifndef CONFIG_KVM
>>> +i
>>> +#endif
>>>         if (vtime_accounting_enabled())
>>>                 vtime_guest_exit(current);
>>>         else
>>>                 __guest_exit();
>>>  }
>>> +EXPORT_SYMBOL_GPL(guest_exit);
>>>  #endif
>>
>> So, what's the real fix for this issue?
>
> So CONFIG_SOMETHING doesn't work when it's a module. Hence we need to
> remove the ifdef CONFIG_KVM around guest_enter(), guest_exit(),
> vtime_guest_enter() and vtime_guest_exit(). Also it seems we need
> <linux/export.h> in context_tracking.c

You mean sth. like this?

- Sedat -

[-- Attachment #2: kvm-Fix-missing-EXPORT_SYMBOL_GPL.diff --]
[-- Type: application/octet-stream, Size: 1717 bytes --]

diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index bbb2c2c..8802a66 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -19,7 +19,7 @@
 #include <linux/rcupdate.h>
 #include <linux/sched.h>
 #include <linux/hardirq.h>
-
+#include <linux/export.h>
 
 DEFINE_PER_CPU(struct context_tracking, context_tracking) = {
 #ifdef CONFIG_CONTEXT_TRACKING_FORCE
@@ -103,7 +103,6 @@ void user_exit(void)
 	local_irq_restore(flags);
 }
 
-#ifdef CONFIG_KVM
 void guest_enter(void)
 {
 	if (vtime_accounting_enabled())
@@ -111,6 +110,7 @@ void guest_enter(void)
 	else
 		__guest_enter();
 }
+EXPORT_SYMBOL_GPL(guest_enter);
 
 void guest_exit(void)
 {
@@ -119,8 +119,7 @@ void guest_exit(void)
 	else
 		__guest_exit();
 }
-#endif
-
+EXPORT_SYMBOL_GPL(guest_exit);
 
 /**
  * context_tracking_task_switch - context switch the syscall callbacks
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 5500a81..dc66cba 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -677,7 +677,6 @@ void vtime_user_enter(struct task_struct *tsk)
 	write_sequnlock(&tsk->vtime_seqlock);
 }
 
-#ifdef CONFIG_KVM
 void vtime_guest_enter(struct task_struct *tsk)
 {
 	write_seqlock(&tsk->vtime_seqlock);
@@ -685,6 +684,7 @@ void vtime_guest_enter(struct task_struct *tsk)
 	current->flags |= PF_VCPU;
 	write_sequnlock(&tsk->vtime_seqlock);
 }
+EXPORT_SYMBOL_GPL(vtime_guest_enter);
 
 void vtime_guest_exit(struct task_struct *tsk)
 {
@@ -693,7 +693,7 @@ void vtime_guest_exit(struct task_struct *tsk)
 	current->flags &= ~PF_VCPU;
 	write_sequnlock(&tsk->vtime_seqlock);
 }
-#endif
+EXPORT_SYMBOL_GPL(vtime_guest_exit);
 
 void vtime_account_idle(struct task_struct *tsk)
 {

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Sedat Dilek]

On Wed, Jan 23, 2013 at 4:20 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote:
> On Wed, Jan 23, 2013 at 4:03 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
>> 2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
>>> On Wed, Jan 23, 2013 at 3:02 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote:
>>>> 2013/1/23 Steven Rostedt <rostedt@goodmis.org>:
>>>>> On Wed, 2013-01-23 at 14:46 +0100, Frederic Weisbecker wrote:
>>>>>
>>>>>> > Hmmm, yes, but why, clueless, CONFIG_KVM=y as a workaround!
>>>>>>
>>>>>> I believe he pointed out the "{i" to you. Typing mistake?
>>>>>
>>>>> In which case the CONFIG_KVM=y is a work around if that {i is within a
>>>>> #ifndef CONFIG_KVM ;-)
>>>>
>>>> No it's in #ifdef CONFIG_KVM so the right fix is:
>>>>
>>>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>>>> index bbb2c2c..a13b8a3 100644
>>>> --- a/kernel/context_tracking.c
>>>> +++ b/kernel/context_tracking.c
>>>> @@ -111,14 +111,19 @@ void guest_enter(void)
>>>>         else
>>>>                 __guest_enter();
>>>>  }
>>>> +EXPORT_SYMBOL_GPL(guest_enter);
>>>>
>>>>  void guest_exit(void)
>>>>  {
>>>> +#ifndef CONFIG_KVM
>>>> +i
>>>> +#endif
>>>>         if (vtime_accounting_enabled())
>>>>                 vtime_guest_exit(current);
>>>>         else
>>>>                 __guest_exit();
>>>>  }
>>>> +EXPORT_SYMBOL_GPL(guest_exit);
>>>>  #endif
>>>
>>> So, what's the real fix for this issue?
>>
>> So CONFIG_SOMETHING doesn't work when it's a module. Hence we need to
>> remove the ifdef CONFIG_KVM around guest_enter(), guest_exit(),
>> vtime_guest_enter() and vtime_guest_exit(). Also it seems we need
>> <linux/export.h> in context_tracking.c
>
> You mean sth. like this?
>

Isn't vtime.h missing in kvm_host.h as an include?

- Sedat -

> - Sedat -

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
>> So CONFIG_SOMETHING doesn't work when it's a module. Hence we need to
>> remove the ifdef CONFIG_KVM around guest_enter(), guest_exit(),
>> vtime_guest_enter() and vtime_guest_exit(). Also it seems we need
>> <linux/export.h> in context_tracking.c
>
> You mean sth. like this?

Almost. vtime_guest_enter/exit don't need to be exported because they
are not referenced by module code: guest_enter/exit are builtin code.

Re: [PATCH 3.8-rc4-nohz3] kvm: Add missing EXPORT_SYMBOL when CONFIG_KVM=m

[Frederic Weisbecker]

2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>:
> Isn't vtime.h missing in kvm_host.h as an include?

No, vtime_guest_enter/exit() are only referenced by context_tracking.c