From: Vivek Gautam <gautam.vivek@samsung.com>
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@ti.com, sarah.a.sharp@linux.intel.com,
kgene.kim@samsung.com, dianders@chromium.org,
sylvester.nawrocki@gmail.com, tomasz.figa@gmail.com
Subject: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend
Date: Mon, 28 Jan 2013 17:12:26 +0530 [thread overview]
Message-ID: <1359373348-18320-3-git-send-email-gautam.vivek@samsung.com> (raw)
In-Reply-To: <1359373348-18320-1-git-send-email-gautam.vivek@samsung.com>
The current code in the dwc3 probe effectively disables runtime pm
from ever working because it calls a get() that was never put() until
device removal. Change the runtime pm code to match the standard
formula and allow runtime pm to function.
Note that this doesn't enable full runtime pm on the DWC3 device in
that the port isn't put into a lower power mode when not used.
However it does allow users of dwc3 (like dwc3-exynos) to do some
amount of runtime power management.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
drivers/usb/dwc3/core.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 3a4004a..59c2494 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -453,6 +453,7 @@ static int dwc3_probe(struct platform_device *pdev)
if (of_get_property(node, "tx-fifo-resize", NULL))
dwc->needs_fifo_resize = true;
+ pm_runtime_set_active(dev);
pm_runtime_enable(dev);
pm_runtime_get_sync(dev);
pm_runtime_forbid(dev);
@@ -517,6 +518,7 @@ static int dwc3_probe(struct platform_device *pdev)
goto err2;
}
+ pm_runtime_put(dev);
pm_runtime_allow(dev);
return 0;
@@ -543,6 +545,7 @@ err1:
err0:
dwc3_free_event_buffers(dwc);
+ pm_runtime_disable(&pdev->dev);
return ret;
}
@@ -554,7 +557,6 @@ static int dwc3_remove(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
dwc3_debugfs_exit(dwc);
--
1.7.6.5
next prev parent reply other threads:[~2013-01-28 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 11:42 [PATCH 0/4] usb: dwc3/xhci: Enable runtime power management Vivek Gautam
2013-01-28 11:42 ` [PATCH 1/4] usb: xhci: Enable runtime pm in xhci-plat Vivek Gautam
2013-01-28 11:42 ` Vivek Gautam [this message]
2013-01-28 11:45 ` [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend Felipe Balbi
2013-01-28 13:36 ` Vivek Gautam
2013-02-27 8:06 ` Felipe Balbi
2013-02-27 8:53 ` Vivek Gautam
2013-01-28 11:42 ` [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management Vivek Gautam
2013-01-28 11:47 ` Felipe Balbi
2013-01-28 11:58 ` Vivek Gautam
2013-01-28 12:12 ` Felipe Balbi
2013-01-28 12:27 ` Vivek Gautam
2013-01-28 12:29 ` Felipe Balbi
2013-01-28 11:42 ` [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3 Vivek Gautam
2013-01-28 12:09 ` Felipe Balbi
2013-01-28 13:04 ` Vivek Gautam
2013-01-28 13:07 ` Felipe Balbi
2013-01-28 13:24 ` Vivek Gautam
2013-01-28 13:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359373348-18320-3-git-send-email-gautam.vivek@samsung.com \
--to=gautam.vivek@samsung.com \
--cc=balbi@ti.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®