mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
	"Gautham R . Shenoy" <gautham.shenoy@amd.com>
Cc: Perry Yuan <perry.yuan@amd.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test
Date: Mon, 21 Oct 2024 18:45:54 +0530	[thread overview]
Message-ID: <135dcf22-bfd1-4624-958c-599f0f3d49dc@amd.com> (raw)
In-Reply-To: <20241017173439.4924-1-mario.limonciello@amd.com>

Hello Mario,

On 10/17/2024 11:04 PM, Mario Limonciello wrote:
> commit 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to
> lowest_nonlinear_freq") changed the iniital minimum frequency to lowest
> nonlinear frequency, but the unit tests weren't updated and now fail.
> 
> Update them to match this same change.

Thanks for the fix, looks good to me.

Regards,
Dhananjay

> 
> Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/cpufreq/amd-pstate-ut.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index f66701514d906..a261d7300951e 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -227,10 +227,10 @@ static void amd_pstate_ut_check_freq(u32 index)
>  			goto skip_test;
>  		}
>  
> -		if (cpudata->min_freq != policy->min) {
> +		if (cpudata->lowest_nonlinear_freq != policy->min) {
>  			amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
> -			pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
> -				__func__, cpu, cpudata->min_freq, policy->min);
> +			pr_err("%s cpu%d cpudata_lowest_nonlinear_freq=%d policy_min=%d, they should be equal!\n",
> +				__func__, cpu, cpudata->lowest_nonlinear_freq, policy->min);
>  			goto skip_test;
>  		}
>  

      reply	other threads:[~2024-10-21 13:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-17 17:34 Mario Limonciello
2024-10-21 13:15 ` Dhananjay Ugwekar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=135dcf22-bfd1-4624-958c-599f0f3d49dc@amd.com \
    --to=dhananjay.ugwekar@amd.com \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perry.yuan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®