* [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test
@ 2024-10-17 17:34 Mario Limonciello
2024-10-21 13:15 ` Dhananjay Ugwekar
0 siblings, 1 reply; 2+ messages in thread
From: Mario Limonciello @ 2024-10-17 17:34 UTC (permalink / raw)
To: Gautham R . Shenoy
Cc: Perry Yuan, linux-kernel, linux-pm, Dhananjay Ugwekar, Mario Limonciello
commit 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to
lowest_nonlinear_freq") changed the iniital minimum frequency to lowest
nonlinear frequency, but the unit tests weren't updated and now fail.
Update them to match this same change.
Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/cpufreq/amd-pstate-ut.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
index f66701514d906..a261d7300951e 100644
--- a/drivers/cpufreq/amd-pstate-ut.c
+++ b/drivers/cpufreq/amd-pstate-ut.c
@@ -227,10 +227,10 @@ static void amd_pstate_ut_check_freq(u32 index)
goto skip_test;
}
- if (cpudata->min_freq != policy->min) {
+ if (cpudata->lowest_nonlinear_freq != policy->min) {
amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
- pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
- __func__, cpu, cpudata->min_freq, policy->min);
+ pr_err("%s cpu%d cpudata_lowest_nonlinear_freq=%d policy_min=%d, they should be equal!\n",
+ __func__, cpu, cpudata->lowest_nonlinear_freq, policy->min);
goto skip_test;
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test
2024-10-17 17:34 [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test Mario Limonciello
@ 2024-10-21 13:15 ` Dhananjay Ugwekar
0 siblings, 0 replies; 2+ messages in thread
From: Dhananjay Ugwekar @ 2024-10-21 13:15 UTC (permalink / raw)
To: Mario Limonciello, Gautham R . Shenoy; +Cc: Perry Yuan, linux-kernel, linux-pm
Hello Mario,
On 10/17/2024 11:04 PM, Mario Limonciello wrote:
> commit 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to
> lowest_nonlinear_freq") changed the iniital minimum frequency to lowest
> nonlinear frequency, but the unit tests weren't updated and now fail.
>
> Update them to match this same change.
Thanks for the fix, looks good to me.
Regards,
Dhananjay
>
> Fixes: 642aff3964b0f ("cpufreq/amd-pstate: Set the initial min_freq to lowest_nonlinear_freq")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/cpufreq/amd-pstate-ut.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index f66701514d906..a261d7300951e 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -227,10 +227,10 @@ static void amd_pstate_ut_check_freq(u32 index)
> goto skip_test;
> }
>
> - if (cpudata->min_freq != policy->min) {
> + if (cpudata->lowest_nonlinear_freq != policy->min) {
> amd_pstate_ut_cases[index].result = AMD_PSTATE_UT_RESULT_FAIL;
> - pr_err("%s cpu%d cpudata_min_freq=%d policy_min=%d, they should be equal!\n",
> - __func__, cpu, cpudata->min_freq, policy->min);
> + pr_err("%s cpu%d cpudata_lowest_nonlinear_freq=%d policy_min=%d, they should be equal!\n",
> + __func__, cpu, cpudata->lowest_nonlinear_freq, policy->min);
> goto skip_test;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-21 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-17 17:34 [PATCH] cpufreq/amd-pstate-ut: Add fix for min freq unit test Mario Limonciello
2024-10-21 13:15 ` Dhananjay Ugwekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®