From: Michael Ellerman <michael@ellerman.id.au>
To: <penberg@kernel.org>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/6] kvm tools: Return error status in lkvm list
Date: Wed, 6 Feb 2013 19:19:11 +1100 [thread overview]
Message-ID: <1360138756-1991-1-git-send-email-michael@ellerman.id.au> (raw)
Currently list always returns 0, even if there was an error. Instead
have it accumulate any errors and return that.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
tools/kvm/builtin-list.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/kvm/builtin-list.c b/tools/kvm/builtin-list.c
index 9299f17..c35be93 100644
--- a/tools/kvm/builtin-list.c
+++ b/tools/kvm/builtin-list.c
@@ -123,7 +123,7 @@ static void parse_setup_options(int argc, const char **argv)
int kvm_cmd_list(int argc, const char **argv, const char *prefix)
{
- int r;
+ int status, r;
parse_setup_options(argc, argv);
@@ -133,17 +133,23 @@ int kvm_cmd_list(int argc, const char **argv, const char *prefix)
printf("%6s %-20s %s\n", "PID", "NAME", "STATE");
printf("------------------------------------\n");
+ status = 0;
+
if (run) {
r = kvm_list_running_instances();
if (r < 0)
perror("Error listing instances");
+
+ status |= r;
}
if (rootfs) {
r = kvm_list_rootfs();
if (r < 0)
perror("Error listing rootfs");
+
+ status |= r;
}
- return 0;
+ return status;
}
--
1.7.10.4
next reply other threads:[~2013-02-06 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 8:19 Michael Ellerman [this message]
2013-02-06 8:19 ` [PATCH 2/6] kvm tools: More error handling in the ipc code Michael Ellerman
2013-02-06 8:19 ` [PATCH 3/6] kvm tools: Rework stdio/stdout handling to support redirection Michael Ellerman
2013-02-06 8:19 ` [PATCH 4/6] kvm tools: powerpc: Fix buglet in xics_init() handling of nrcpus Michael Ellerman
2013-02-06 8:19 ` [PATCH 5/6] kvm tools: powerpc: Add cpu info entry for POWER8 Michael Ellerman
2013-02-06 8:19 ` [PATCH 6/6] kvm tools: powerpc: Only emit TB freq if it's non-zero Michael Ellerman
2013-02-06 11:16 ` [PATCH 1/6] kvm tools: Return error status in lkvm list Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360138756-1991-1-git-send-email-michael@ellerman.id.au \
--to=michael@ellerman.id.au \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®