mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: <penberg@kernel.org>
Cc: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/6] kvm tools: powerpc: Fix buglet in xics_init() handling of nrcpus
Date: Wed,  6 Feb 2013 19:19:14 +1100	[thread overview]
Message-ID: <1360138756-1991-4-git-send-email-michael@ellerman.id.au> (raw)
In-Reply-To: <1360138756-1991-1-git-send-email-michael@ellerman.id.au>

In xics_init() we set the maximum server to kvm->nrcpus, and then set
the nr_servers using maximum server + 1.

That is off by one, in the harmless direction.

Simplify it to just set nr_servers = kvm->nrcpus.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 tools/kvm/powerpc/xics.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tools/kvm/powerpc/xics.c b/tools/kvm/powerpc/xics.c
index d4b5caa..cf64a08 100644
--- a/tools/kvm/powerpc/xics.c
+++ b/tools/kvm/powerpc/xics.c
@@ -445,16 +445,13 @@ static void rtas_int_on(struct kvm_cpu *vcpu, uint32_t token,
 
 static int xics_init(struct kvm *kvm)
 {
-	int max_server_num;
 	unsigned int i;
 	struct icp_state *icp;
 	struct ics_state *ics;
 	int j;
 
-	max_server_num = kvm->nrcpus;
-
 	icp = malloc(sizeof(*icp));
-	icp->nr_servers = max_server_num + 1;
+	icp->nr_servers = kvm->nrcpus;
 	icp->ss = malloc(icp->nr_servers * sizeof(struct icp_server_state));
 
 	for (i = 0; i < icp->nr_servers; i++) {
-- 
1.7.10.4


  parent reply	other threads:[~2013-02-06  8:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06  8:19 [PATCH 1/6] kvm tools: Return error status in lkvm list Michael Ellerman
2013-02-06  8:19 ` [PATCH 2/6] kvm tools: More error handling in the ipc code Michael Ellerman
2013-02-06  8:19 ` [PATCH 3/6] kvm tools: Rework stdio/stdout handling to support redirection Michael Ellerman
2013-02-06  8:19 ` Michael Ellerman [this message]
2013-02-06  8:19 ` [PATCH 5/6] kvm tools: powerpc: Add cpu info entry for POWER8 Michael Ellerman
2013-02-06  8:19 ` [PATCH 6/6] kvm tools: powerpc: Only emit TB freq if it's non-zero Michael Ellerman
2013-02-06 11:16 ` [PATCH 1/6] kvm tools: Return error status in lkvm list Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360138756-1991-4-git-send-email-michael@ellerman.id.au \
    --to=michael@ellerman.id.au \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®