mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: <netdev@vger.kernel.org>, Eilon Greenstein <eilong@broadcom.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Bruce Allan <bruce.w.allan@intel.com>,
	Carolyn Wyborny <carolyn.wyborny@intel.com>,
	Don Skidmore <donald.c.skidmore@intel.com>,
	Greg Rose <gregory.v.rose@intel.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
	Alex Duyck <alexander.h.duyck@intel.com>,
	John Ronciak <john.ronciak@intel.com>,
	Tushar Dave <tushar.n.dave@intel.com>,
	Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>,
	Sony Chacko <sony.chacko@qlogic.com>, <linux-driver@qlogic.com>,
	John Fastabend <john.r.fastabend@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jacob Keller <jacob.e.keller@intel.com>,
	<linux-kernel@vger.kernel.org>,
	<e1000-devel@lists.sourceforge.net>, <eric.dumazet@gmail.com>
Subject: Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO
Date: Wed, 6 Feb 2013 23:34:20 +0000	[thread overview]
Message-ID: <1360193660.32217.39.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <cover.1360191528.git.mst@redhat.com>

On Thu, 2013-02-07 at 01:02 +0200, Michael S. Tsirkin wrote:
> At the moment, macvtap crashes are observed if macvtap is attached
> to an interface with LRO enabled.
> The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
> This happens because several drivers set gso_size but not gso_type
> in incoming skbs.
> The following patches fix this for
> Additionally, cbf1de72324a8105ddcc3d9ce9acbc613faea17e is required
> to fix this for broadcom - would it make sense to cherry-pick
> this patch into 3.8?
> 
> I tested that the patch fixes the crash for ixgbe but
> don't have qlogic hardware to fix.  I also only tested TCP.
> 
> Feedback wellcome.

If we want to allow forwarding from LRO then net/ipv4/inet_lro.c also
needs to set gso_type.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  parent reply	other threads:[~2013-02-06 23:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-06 23:02 Michael S. Tsirkin
2013-02-06 23:02 ` [PATCH 1/2] ixgbe: fix gso type Michael S. Tsirkin
2013-02-07  3:21   ` Eric Dumazet
2013-02-06 23:02 ` [PATCH 2/2] qlcnic: set gso_type Michael S. Tsirkin
2013-02-07  3:20   ` Eric Dumazet
2013-02-07  8:16     ` Michael S. Tsirkin
2013-02-06 23:34 ` Ben Hutchings [this message]
2013-02-07  3:18   ` [PATCH 0/2] fix kernel crash with macvtap on top of LRO Eric Dumazet
2013-02-07 16:20     ` Ben Hutchings
2013-02-07 18:14       ` David Miller
2013-02-07 21:33         ` Michael S. Tsirkin
2013-02-07 22:31           ` Ben Hutchings
2013-02-11  1:15             ` David Miller
2013-06-10  7:07         ` Michael S. Tsirkin
2013-06-12 14:56           ` Ben Hutchings
2013-06-12 19:00             ` Michael S. Tsirkin
2013-06-17  1:35               ` Rusty Russell
2013-06-17 16:20                 ` Ben Hutchings
2013-06-18  5:12                   ` Rusty Russell
2013-02-07  3:25 ` Cong Wang
2013-02-07  8:15   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360193660.32217.39.camel@deadeye.wl.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=bruce.w.allan@intel.com \
    --cc=carolyn.wyborny@intel.com \
    --cc=davem@davemloft.net \
    --cc=donald.c.skidmore@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=eilong@broadcom.com \
    --cc=eric.dumazet@gmail.com \
    --cc=gregory.v.rose@intel.com \
    --cc=jacob.e.keller@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=jitendra.kalsaria@qlogic.com \
    --cc=john.r.fastabend@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=sony.chacko@qlogic.com \
    --cc=tushar.n.dave@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®