From: Ben Hutchings <bhutchings@solarflare.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>, <eric.dumazet@gmail.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<rusty@rustcorp.com.au>,
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH 0/2] fix kernel crash with macvtap on top of LRO
Date: Wed, 12 Jun 2013 15:56:36 +0100 [thread overview]
Message-ID: <1371048996.1894.15.camel@bwh-desktop.uk.level5networks.com> (raw)
In-Reply-To: <20130610070710.GA673@redhat.com>
On Mon, 2013-06-10 at 10:07 +0300, Michael S. Tsirkin wrote:
> On Thu, Feb 07, 2013 at 01:14:20PM -0500, David Miller wrote:
> > From: Ben Hutchings <bhutchings@solarflare.com>
> > Date: Thu, 7 Feb 2013 16:20:46 +0000
> >
> > > If the consensus is still that we must preserve packets exactly (aside
> > > from the usual modifications by IP routers) then LRO should be disabled
> > > on all devices for which forwarding is enabled.
> >
> > I believe this is still undoubtedly the consensus.
>
> With virtio we are getting packets from a linux host,
> so we could thinkably preserve packets exactly
> even with LRO. I am guessing other hardware could be
> doing this as well.
>
> I am not sure what information would need to be preserved -
> could someone help clarify please?
Some LRO implementations may not preserve:
- Packet boundaries
- TSO/GSO produces packets all the same size, except possibly for the
last one. GRO therefore flushes a flow after merging a packet with
a different segment size.
- IPv4 TTL, IPv6 hop-limit, TCP timestamp
- TSO/GSO will put the same values in all packets. GRO flushes a flow
if they change.
- IPv4 fragment ID
- TSO/GSO produces consecutive fragment IDs. GRO flushes a flow
if it sees a non-consecutive fragment ID.
- MAC header, IPv4 TOS, IPv6 traffic class
- Should be the same for all packets in a flow. GRO actually checks
and flushes a flow if they change.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2013-06-12 14:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 23:02 Michael S. Tsirkin
2013-02-06 23:02 ` [PATCH 1/2] ixgbe: fix gso type Michael S. Tsirkin
2013-02-07 3:21 ` Eric Dumazet
2013-02-06 23:02 ` [PATCH 2/2] qlcnic: set gso_type Michael S. Tsirkin
2013-02-07 3:20 ` Eric Dumazet
2013-02-07 8:16 ` Michael S. Tsirkin
2013-02-06 23:34 ` [PATCH 0/2] fix kernel crash with macvtap on top of LRO Ben Hutchings
2013-02-07 3:18 ` Eric Dumazet
2013-02-07 16:20 ` Ben Hutchings
2013-02-07 18:14 ` David Miller
2013-02-07 21:33 ` Michael S. Tsirkin
2013-02-07 22:31 ` Ben Hutchings
2013-02-11 1:15 ` David Miller
2013-06-10 7:07 ` Michael S. Tsirkin
2013-06-12 14:56 ` Ben Hutchings [this message]
2013-06-12 19:00 ` Michael S. Tsirkin
2013-06-17 1:35 ` Rusty Russell
2013-06-17 16:20 ` Ben Hutchings
2013-06-18 5:12 ` Rusty Russell
2013-02-07 3:25 ` Cong Wang
2013-02-07 8:15 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371048996.1894.15.camel@bwh-desktop.uk.level5networks.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®