mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <tony@atomide.com>
Cc: <b-cousson@ti.com>, <balbi@ti.com>, <gregkh@linuxfoundation.org>,
	<stern@rowland.harvard.edu>, <linux@arm.linux.org.uk>,
	<kishon@ti.com>, <mark.rutland@arm.com>, <rogerq@ti.com>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 02/14] USB: phy: nop: Defer probe if device needs VCC/RESET
Date: Thu, 7 Feb 2013 18:02:42 +0200	[thread overview]
Message-ID: <1360252974-7912-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1360252974-7912-1-git-send-email-rogerq@ti.com>

Add 2 flags, needs_vcc and needs_reset to platform data.
If the flag is set and the regulator couldn't be found
then we bail out with -EPROBE_DEFER.

For device tree boot we depend on presensce of vcc-supply/
reset-supply properties to decide if we should bail out
with -EPROBE_DEFER or just continue in case the regulator
can't be found.

This is required for proper functionality in cases where the
regulator is needed but is probed later than the PHY device.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>
---
 drivers/usb/otg/nop-usb-xceiv.c   |   11 +++++++++++
 include/linux/usb/nop-usb-xceiv.h |    4 ++++
 2 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c
index 6b7a9a0..7b0e8a8 100644
--- a/drivers/usb/otg/nop-usb-xceiv.c
+++ b/drivers/usb/otg/nop-usb-xceiv.c
@@ -43,6 +43,8 @@ struct nop_usb_xceiv {
 	struct regulator *vcc;
 	struct regulator *reset;
 	u32 clk_rate;
+	unsigned int needs_vcc:1;
+	unsigned int needs_reset:1;
 };
 
 static struct platform_device *pd;
@@ -163,9 +165,14 @@ static int nop_usb_xceiv_probe(struct platform_device *pdev)
 		if (!of_property_read_u32(node, "clock-frequency", &clk_rate))
 			nop->clk_rate = clk_rate;
 
+		nop->needs_vcc = of_property_read_bool(node, "vcc-supply");
+		nop->needs_reset = of_property_read_bool(node, "reset-supply");
+
 	} else if (pdata) {
 		type = pdata->type;
 		nop->clk_rate = pdata->clk_rate;
+		nop->needs_vcc = pdata->needs_vcc;
+		nop->needs_reset = pdata->needs_reset;
 	}
 
 	nop->clk = devm_clk_get(&pdev->dev, "main_clk");
@@ -194,12 +201,16 @@ static int nop_usb_xceiv_probe(struct platform_device *pdev)
 	if (IS_ERR(nop->vcc)) {
 		dev_dbg(&pdev->dev, "Error getting vcc regulator: %ld\n",
 					PTR_ERR(nop->vcc));
+		if (nop->needs_vcc)
+			return -EPROBE_DEFER;
 	}
 
 	nop->reset = devm_regulator_get(&pdev->dev, "reset");
 	if (IS_ERR(nop->reset)) {
 		dev_dbg(&pdev->dev, "Error getting reset regulator: %ld\n",
 					PTR_ERR(nop->reset));
+		if (nop->needs_reset)
+			return -EPROBE_DEFER;
 	}
 
 	nop->dev		= &pdev->dev;
diff --git a/include/linux/usb/nop-usb-xceiv.h b/include/linux/usb/nop-usb-xceiv.h
index 3265b61..148d351 100644
--- a/include/linux/usb/nop-usb-xceiv.h
+++ b/include/linux/usb/nop-usb-xceiv.h
@@ -6,6 +6,10 @@
 struct nop_usb_xceiv_platform_data {
 	enum usb_phy_type type;
 	unsigned long clk_rate;
+
+	/* if set fails with -EPROBE_DEFER if can't get regulator */
+	unsigned int needs_vcc:1;
+	unsigned int needs_reset:1;
 };
 
 #if defined(CONFIG_NOP_USB_XCEIV) || (defined(CONFIG_NOP_USB_XCEIV_MODULE) && defined(MODULE))
-- 
1.7.4.1


  parent reply	other threads:[~2013-02-07 16:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 16:02 [PATCH v2 00/14] Device tree support for OMAP HS USB Host Roger Quadros
2013-02-07 16:02 ` [PATCH v2 01/14] usb: phy: nop: Add device tree support and binding information Roger Quadros
2013-02-11 11:40   ` Mark Rutland
2013-02-11 15:14     ` Roger Quadros
2013-02-11 15:31       ` Mark Rutland
2013-02-07 16:02 ` Roger Quadros [this message]
2013-02-07 16:02 ` [PATCH v2 03/14] mfd: omap-usb-tll: move configuration code to omap_tll_init() Roger Quadros
2013-02-07 16:02 ` [PATCH v2 04/14] mfd: omap-usb-tll: Add device tree support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 05/14] USB: ehci-omap: Get platform resources by index rather than by name Roger Quadros
2013-02-07 16:02 ` [PATCH v2 06/14] USB: ohci-omap3: " Roger Quadros
2013-02-07 16:02 ` [PATCH v2 07/14] USB: ohci-omap3: Add device tree support and binding information Roger Quadros
2013-02-11 11:46   ` Mark Rutland
2013-02-11 15:22     ` Roger Quadros
2013-02-11 15:32       ` Mark Rutland
2013-02-07 16:02 ` [PATCH v2 08/14] USB: ehci-omap: " Roger Quadros
2013-02-11 11:52   ` Mark Rutland
2013-02-07 16:02 ` [PATCH v2 09/14] mfd: omap-usb-host: " Roger Quadros
2013-02-11 12:00   ` Mark Rutland
2013-02-11 15:24     ` Roger Quadros
2013-02-07 16:02 ` [PATCH v2 10/14] ARM: dts: OMAP4: Add HS USB Host IP nodes Roger Quadros
2013-02-07 16:02 ` [PATCH v2 11/14] ARM: dts: omap4-panda: Add USB Host support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 12/14] ARM: dts: OMAP3: Add HS USB Host IP nodes Roger Quadros
2013-02-07 16:02 ` [PATCH v2 13/14] ARM: dts: omap3-beagle: Add USB Host support Roger Quadros
2013-02-07 16:02 ` [PATCH v2 14/14] USB: ehci-omap: Fix autoloading of module Roger Quadros
2013-02-07 16:11   ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360252974-7912-3-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®