From: Arnd Bergmann <arnd@arndb.de>
To: arm@kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-i2c@vger.kernel.org, Wolfram Sang <w.sang@pengutronix.de>,
Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>
Subject: [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration
Date: Thu, 14 Feb 2013 14:49:26 +0100 [thread overview]
Message-ID: <1360849767-1463135-11-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1360849767-1463135-1-git-send-email-arnd@arndb.de>
A recent cleanup to the mach-osiris.c file is causing build errors
because the i2c-s3c2410.h header file is included before we see
the definition for platform_device. The fix is to make the header file
more robust against inclusion from other places. While this should
normally go through the i2c tree, the bug only exists in arm-soc
at the moment, so it's easier to fix it there before it goes upstream.
Without this patch, building s3c2410_defconfig results in:
arch/arm/mach-s3c24xx/mach-osiris.c:34:0:
include/linux/platform_data/i2c-s3c2410.h:37:26: warning: 'struct platform_device' declared inside parameter list [enabled by default]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
---
include/linux/platform_data/i2c-s3c2410.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/platform_data/i2c-s3c2410.h b/include/linux/platform_data/i2c-s3c2410.h
index 51d52e7..2a50048 100644
--- a/include/linux/platform_data/i2c-s3c2410.h
+++ b/include/linux/platform_data/i2c-s3c2410.h
@@ -15,6 +15,8 @@
#define S3C_IICFLG_FILTER (1<<0) /* enable s3c2440 filter */
+struct platform_device;
+
/**
* struct s3c2410_platform_i2c - Platform data for s3c I2C.
* @bus_num: The bus number to use (if possible).
--
1.8.1.2
next prev parent reply other threads:[~2013-02-14 13:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 13:49 [PATCH 00/11] ARM warning fixes for arm-soc Arnd Bergmann
2013-02-14 13:49 ` [PATCH 01/11] ARM: disable virt_to_bus/virt_to_bus almost everywhere Arnd Bergmann
2013-02-16 22:18 ` Emilio López
2013-02-16 23:15 ` Arnd Bergmann
2013-02-20 15:14 ` James Hogan
2013-02-20 16:00 ` Arnd Bergmann
2013-02-20 16:32 ` James Hogan
2013-02-21 7:37 ` Vineet Gupta
2013-02-21 23:13 ` Stephen Rothwell
2013-02-25 14:18 ` Vineet Gupta
2013-02-25 14:54 ` Arnd Bergmann
2013-02-14 13:49 ` [PATCH 02/11] ARM: samsung: fix assembly syntax for new gas Arnd Bergmann
2013-02-16 23:25 ` Russell King - ARM Linux
2013-02-17 14:01 ` Arnd Bergmann
2013-02-17 15:37 ` Mikael Pettersson
2013-02-17 15:47 ` Arnd Bergmann
2013-02-17 0:38 ` Aaro Koskinen
2013-02-17 15:37 ` Arnd Bergmann
2013-02-14 13:49 ` [PATCH 03/11] ARM: w90x900: fix legacy assembly syntax Arnd Bergmann
2013-02-14 13:49 ` [PATCH 04/11] ARM: shmobile: fix defconfig warning on CONFIG_USB Arnd Bergmann
2013-02-14 13:49 ` [PATCH 05/11] ARM: sa1100: don't warn about mach/ide.h Arnd Bergmann
2013-02-14 13:49 ` [PATCH 06/11] ARM: integrator/versatile: fix NOMMU warnings Arnd Bergmann
2013-02-15 9:12 ` Linus Walleij
2013-02-14 13:49 ` [PATCH 07/11] ARM: integrator: fix build with INTEGRATOR_AP off Arnd Bergmann
2013-02-15 9:13 ` Linus Walleij
2013-02-14 13:49 ` [PATCH 08/11] ARM: pick Versatile by default for !MMU Arnd Bergmann
2013-02-14 13:49 ` [PATCH 09/11] ARM: mvebu: allow selecting mvebu without Armada XP Arnd Bergmann
2013-02-14 13:49 ` Arnd Bergmann [this message]
2013-02-15 11:54 ` [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration Wolfram Sang
2013-02-14 13:49 ` [PATCH 11/11] scripts/sortextable: silence script output Arnd Bergmann
2013-02-14 19:25 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360849767-1463135-11-git-send-email-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®