mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: arm@kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 01/11] ARM: disable virt_to_bus/virt_to_bus almost everywhere
Date: Thu, 14 Feb 2013 14:49:17 +0100	[thread overview]
Message-ID: <1360849767-1463135-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1360849767-1463135-1-git-send-email-arnd@arndb.de>

We are getting a number of warnings about the use of the deprecated
bus_to_virt function in drivers using the ARM ISA DMA API:

drivers/parport/parport_pc.c: In function 'parport_pc_fifo_write_block_dma':
drivers/parport/parport_pc.c:622:3: warning: 'bus_to_virt' is deprecated
(declared at arch/arm/include/asm/memory.h:253) [-Wdeprecated-declarations]

This is only because that function gets used by the inline
set_dma_addr() helper. We know that any driver for the ISA DMA API
is correctly using the DMA addresses, so we can change this
to use the __bus_to_virt() function instead, which does not warn.

After this, there are no remaining drivers that are used on
any defconfigs on ARM using virt_to_bus or bus_to_virt, with
the exception of the OSS sound driver. That driver is only used
on RiscPC, NetWinder and Shark, so we can set ARCH_NO_VIRT_TO_BUS
on all other platforms and hide the deprecated functions, which
is far more effective than marking them as deprecated, in order
to avoid any new users of that code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <linux@arm.linux.org.uk>
---
 arch/arm/Kconfig                 | 4 ++++
 arch/arm/configs/shark_defconfig | 1 -
 arch/arm/include/asm/dma.h       | 2 +-
 arch/arm/include/asm/memory.h    | 2 ++
 4 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 67874b8..91d4aea 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1450,6 +1450,10 @@ config ISA_DMA
 	bool
 	select ISA_DMA_API
 
+config ARCH_NO_VIRT_TO_BUS
+	def_bool y
+	depends on !ARCH_RPC && !ARCH_NETWINDER && !ARCH_SHARK
+
 # Select ISA DMA interface
 config ISA_DMA_API
 	bool
diff --git a/arch/arm/configs/shark_defconfig b/arch/arm/configs/shark_defconfig
index caa07db..e319b2c 100644
--- a/arch/arm/configs/shark_defconfig
+++ b/arch/arm/configs/shark_defconfig
@@ -73,7 +73,6 @@ CONFIG_PARTITION_ADVANCED=y
 CONFIG_NLS_CODEPAGE_437=m
 CONFIG_NLS_CODEPAGE_850=m
 CONFIG_NLS_ISO8859_1=m
-# CONFIG_ENABLE_WARN_DEPRECATED is not set
 # CONFIG_ENABLE_MUST_CHECK is not set
 CONFIG_DEBUG_KERNEL=y
 # CONFIG_SCHED_DEBUG is not set
diff --git a/arch/arm/include/asm/dma.h b/arch/arm/include/asm/dma.h
index 5694a0d..58b8c6a 100644
--- a/arch/arm/include/asm/dma.h
+++ b/arch/arm/include/asm/dma.h
@@ -105,7 +105,7 @@ extern void set_dma_sg(unsigned int chan, struct scatterlist *sg, int nr_sg);
  */
 extern void __set_dma_addr(unsigned int chan, void *addr);
 #define set_dma_addr(chan, addr)				\
-	__set_dma_addr(chan, bus_to_virt(addr))
+	__set_dma_addr(chan, (void *)__bus_to_virt(addr))
 
 /* Set the DMA byte count for this channel
  *
diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
index 1c4df27..474e2e6 100644
--- a/arch/arm/include/asm/memory.h
+++ b/arch/arm/include/asm/memory.h
@@ -245,6 +245,7 @@ static inline void *phys_to_virt(phys_addr_t x)
 #define __bus_to_pfn(x)	__phys_to_pfn(x)
 #endif
 
+#ifdef CONFIG_VIRT_TO_BUS
 static inline __deprecated unsigned long virt_to_bus(void *x)
 {
 	return __virt_to_bus((unsigned long)x);
@@ -254,6 +255,7 @@ static inline __deprecated void *bus_to_virt(unsigned long x)
 {
 	return (void *)__bus_to_virt(x);
 }
+#endif
 
 /*
  * Conversion between a struct page and a physical address.
-- 
1.8.1.2


  reply	other threads:[~2013-02-14 13:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 13:49 [PATCH 00/11] ARM warning fixes for arm-soc Arnd Bergmann
2013-02-14 13:49 ` Arnd Bergmann [this message]
2013-02-16 22:18   ` [PATCH 01/11] ARM: disable virt_to_bus/virt_to_bus almost everywhere Emilio López
2013-02-16 23:15     ` Arnd Bergmann
2013-02-20 15:14   ` James Hogan
2013-02-20 16:00     ` Arnd Bergmann
2013-02-20 16:32       ` James Hogan
2013-02-21  7:37         ` Vineet Gupta
2013-02-21 23:13           ` Stephen Rothwell
2013-02-25 14:18             ` Vineet Gupta
2013-02-25 14:54               ` Arnd Bergmann
2013-02-14 13:49 ` [PATCH 02/11] ARM: samsung: fix assembly syntax for new gas Arnd Bergmann
2013-02-16 23:25   ` Russell King - ARM Linux
2013-02-17 14:01     ` Arnd Bergmann
2013-02-17 15:37     ` Mikael Pettersson
2013-02-17 15:47       ` Arnd Bergmann
2013-02-17  0:38   ` Aaro Koskinen
2013-02-17 15:37     ` Arnd Bergmann
2013-02-14 13:49 ` [PATCH 03/11] ARM: w90x900: fix legacy assembly syntax Arnd Bergmann
2013-02-14 13:49 ` [PATCH 04/11] ARM: shmobile: fix defconfig warning on CONFIG_USB Arnd Bergmann
2013-02-14 13:49 ` [PATCH 05/11] ARM: sa1100: don't warn about mach/ide.h Arnd Bergmann
2013-02-14 13:49 ` [PATCH 06/11] ARM: integrator/versatile: fix NOMMU warnings Arnd Bergmann
2013-02-15  9:12   ` Linus Walleij
2013-02-14 13:49 ` [PATCH 07/11] ARM: integrator: fix build with INTEGRATOR_AP off Arnd Bergmann
2013-02-15  9:13   ` Linus Walleij
2013-02-14 13:49 ` [PATCH 08/11] ARM: pick Versatile by default for !MMU Arnd Bergmann
2013-02-14 13:49 ` [PATCH 09/11] ARM: mvebu: allow selecting mvebu without Armada XP Arnd Bergmann
2013-02-14 13:49 ` [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration Arnd Bergmann
2013-02-15 11:54   ` Wolfram Sang
2013-02-14 13:49 ` [PATCH 11/11] scripts/sortextable: silence script output Arnd Bergmann
2013-02-14 19:25   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360849767-1463135-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=arm@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®