* [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch
@ 2013-02-21 18:10 Silviu-Mihai Popescu
2013-02-21 18:15 ` Myklebust, Trond
0 siblings, 1 reply; 2+ messages in thread
From: Silviu-Mihai Popescu @ 2013-02-21 18:10 UTC (permalink / raw)
To: netdev; +Cc: Trond.Myklebust, bfields, davem, linux-nfs, linux-kernel
This fixes the following sparse warnings:
* net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol
'_gss_mech_get_by_name' was not declared. Should it be static?
* net/sunrpc/auth_gss/gss_mech_switch.c:208:21: warning: symbol
'_gss_mech_get_by_pseudoflavor' was not declared. Should it be static?
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
net/sunrpc/auth_gss/gss_mech_switch.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
index b174fcd..f0f4eee 100644
--- a/net/sunrpc/auth_gss/gss_mech_switch.c
+++ b/net/sunrpc/auth_gss/gss_mech_switch.c
@@ -140,7 +140,7 @@ gss_mech_get(struct gss_api_mech *gm)
EXPORT_SYMBOL_GPL(gss_mech_get);
-struct gss_api_mech *
+static struct gss_api_mech *
_gss_mech_get_by_name(const char *name)
{
struct gss_api_mech *pos, *gm = NULL;
@@ -205,7 +205,7 @@ mech_supports_pseudoflavor(struct gss_api_mech *gm, u32 pseudoflavor)
return 0;
}
-struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor)
+static struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor)
{
struct gss_api_mech *gm = NULL, *pos;
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch
2013-02-21 18:10 [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch Silviu-Mihai Popescu
@ 2013-02-21 18:15 ` Myklebust, Trond
0 siblings, 0 replies; 2+ messages in thread
From: Myklebust, Trond @ 2013-02-21 18:15 UTC (permalink / raw)
To: Silviu-Mihai Popescu; +Cc: netdev, bfields, davem, linux-nfs, linux-kernel
On Thu, 2013-02-21 at 20:10 +0200, Silviu-Mihai Popescu wrote:
> This fixes the following sparse warnings:
> * net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol
> '_gss_mech_get_by_name' was not declared. Should it be static?
> * net/sunrpc/auth_gss/gss_mech_switch.c:208:21: warning: symbol
> '_gss_mech_get_by_pseudoflavor' was not declared. Should it be static?
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> ---
> net/sunrpc/auth_gss/gss_mech_switch.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_mech_switch.c b/net/sunrpc/auth_gss/gss_mech_switch.c
> index b174fcd..f0f4eee 100644
> --- a/net/sunrpc/auth_gss/gss_mech_switch.c
> +++ b/net/sunrpc/auth_gss/gss_mech_switch.c
> @@ -140,7 +140,7 @@ gss_mech_get(struct gss_api_mech *gm)
>
> EXPORT_SYMBOL_GPL(gss_mech_get);
>
> -struct gss_api_mech *
> +static struct gss_api_mech *
> _gss_mech_get_by_name(const char *name)
> {
> struct gss_api_mech *pos, *gm = NULL;
> @@ -205,7 +205,7 @@ mech_supports_pseudoflavor(struct gss_api_mech *gm, u32 pseudoflavor)
> return 0;
> }
>
> -struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor)
> +static struct gss_api_mech *_gss_mech_get_by_pseudoflavor(u32 pseudoflavor)
> {
> struct gss_api_mech *gm = NULL, *pos;
>
This is identical to commit c5f5e9c5d2e9178fb0bfe4f44f0afcc8ad6488ef
(SUNRPC: Add missing static declaration to _gss_mech_get_by_name) which
is already upstream.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-21 18:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-21 18:10 [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch Silviu-Mihai Popescu
2013-02-21 18:15 ` Myklebust, Trond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®