* [PATCH] staging: line6: pod.c: fix checkpatch warning
@ 2013-02-25 13:08 Laurent Navet
2013-02-25 13:18 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Navet @ 2013-02-25 13:08 UTC (permalink / raw)
To: gregkh; +Cc: stefanha, morbidrsa, devel, linux-kernel, Laurent Navet
- WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
---
drivers/staging/line6/pod.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 74898c3..699b217 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -148,9 +148,8 @@ void line6_pod_process_message(struct usb_line6_pod *pod)
buf[0] != (LINE6_SYSEX_BEGIN | LINE6_CHANNEL_UNKNOWN)) {
return;
}
- if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) != 0) {
+ if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) != 0)
return;
- }
if (buf[5] == POD_SYSEX_SYSTEM && buf[6] == POD_MONITOR_LEVEL) {
short value = ((int)buf[7] << 12) | ((int)buf[8] << 8) |
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: line6: pod.c: fix checkpatch warning
2013-02-25 13:08 [PATCH] staging: line6: pod.c: fix checkpatch warning Laurent Navet
@ 2013-02-25 13:18 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2013-02-25 13:18 UTC (permalink / raw)
To: Laurent Navet; +Cc: Greg Kroah-Hartman, johannes thumshirn, devel, linux-kernel
On Mon, Feb 25, 2013 at 2:08 PM, Laurent Navet <laurent.navet@gmail.com> wrote:
> - WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Laurent Navet <laurent.navet@gmail.com>
> ---
> drivers/staging/line6/pod.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-25 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-25 13:08 [PATCH] staging: line6: pod.c: fix checkpatch warning Laurent Navet
2013-02-25 13:18 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®