mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, hpa@zytor.com,
	gregkh@linuxfoundation.org, x86@kernel.org
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH 3/3] docs: Fix incorrect comment about 64-bit code segment descriptors.
Date: Mon, 25 Feb 2013 15:54:10 -0500	[thread overview]
Message-ID: <1361825650-14031-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1361825650-14031-1-git-send-email-konrad.wilk@oracle.com>

The AMD64 Architecture Programmer's Manual Volume 2, on page
89 mentions: "If the processor is running in 64-bit mode (L=1),
the only valid setting of the D bit is 0." This matches
with what the code does.

CC: hpa@zytor.com
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/kernel/head_64.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index b7de3b2..6859e96 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -48,7 +48,7 @@ L3_START_KERNEL = pud_index(__START_KERNEL_map)
 	.globl startup_64
 startup_64:
 	/*
-	 * At this point the CPU runs in 64bit mode CS.L = 1 CS.D = 1,
+	 * At this point the CPU runs in 64bit mode CS.L = 1 CS.D = 0,
 	 * and someone has loaded an identity mapped page table
 	 * for us.  These identity mapped page tables map all of the
 	 * kernel pages and possibly all of memory.
@@ -159,7 +159,7 @@ startup_64:
 	jmp 1f
 ENTRY(secondary_startup_64)
 	/*
-	 * At this point the CPU runs in 64bit mode CS.L = 1 CS.D = 1,
+	 * At this point the CPU runs in 64bit mode CS.L = 1 CS.D = 0,
 	 * and someone has loaded a mapped page table.
 	 *
 	 * %rsi holds a physical pointer to real_mode_data.
-- 
1.8.0.2


  parent reply	other threads:[~2013-02-25 20:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-25 20:54 [PATCH] Documentation and source code comments updates (v1) Konrad Rzeszutek Wilk
2013-02-25 20:54 ` [PATCH 1/3] xen/documentation: Mention 'earlyprintk=xen' in the documentation Konrad Rzeszutek Wilk
2013-02-25 22:13   ` [tip:x86/urgent] doc, xen: " tip-bot for Konrad Rzeszutek Wilk
2013-02-25 20:54 ` [PATCH 2/3] kernel-parameters: Document 'console=hvc<n>' Konrad Rzeszutek Wilk
2013-02-25 22:14   ` [tip:x86/urgent] doc, kernel-parameters: Document 'console=hvc<n> ' tip-bot for Konrad Rzeszutek Wilk
2013-02-25 20:54 ` Konrad Rzeszutek Wilk [this message]
2013-02-25 22:15   ` [tip:x86/urgent] x86, doc: Fix incorrect comment about 64-bit code segment descriptors tip-bot for Konrad Rzeszutek Wilk
2013-02-26  5:08 ` [PATCH] Documentation and source code comments updates (v1) Rob Landley
2013-02-26 16:40   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361825650-14031-4-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®