* [PATCH 1/6] In acpi_memory_device_notify()
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
2013-03-05 8:23 ` [PATCH 2/6] In acpi_get_table_with_size() Tang Chen
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/acpi/acpi_memhotplug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index da1f82b..8a10c23 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
kfree(ej_event);
}
- unlock:
+unlock:
acpi_scan_lock_release();
if (ACPI_SUCCESS(status))
return;
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/6] In acpi_get_table_with_size()
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
2013-03-05 8:23 ` [PATCH 1/6] In acpi_memory_device_notify() Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
2013-03-05 8:23 ` [PATCH 3/6] In acpi_tb_table_override() Tang Chen
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
In the comment of acpi_get_table_with_size(), one parameter tbl_size
is missing. And the definitions of i and j begin with space, not tab.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/acpi/acpica/tbxface.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
index b35a5e6..93d1432 100644
--- a/drivers/acpi/acpica/tbxface.c
+++ b/drivers/acpi/acpica/tbxface.c
@@ -304,6 +304,7 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
* PARAMETERS: signature - ACPI signature of needed table
* instance - Which instance (for SSDTs)
* out_table - Where the pointer to the table is returned
+ * tbl_size - Size of the table
*
* RETURN: Status and pointer to table
*
@@ -315,8 +316,7 @@ acpi_get_table_with_size(char *signature,
u32 instance, struct acpi_table_header **out_table,
acpi_size *tbl_size)
{
- u32 i;
- u32 j;
+ u32 i, j;
acpi_status status;
/* Parameter validation */
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/6] In acpi_tb_table_override()
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
2013-03-05 8:23 ` [PATCH 1/6] In acpi_memory_device_notify() Tang Chen
2013-03-05 8:23 ` [PATCH 2/6] In acpi_get_table_with_size() Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
2013-03-05 8:23 ` [PATCH 4/6] In acpi_tb_install_table() Tang Chen
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/acpi/acpica/tbinstal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpica/tbinstal.c b/drivers/acpi/acpica/tbinstal.c
index e57cd38..b1e098d 100644
--- a/drivers/acpi/acpica/tbinstal.c
+++ b/drivers/acpi/acpica/tbinstal.c
@@ -313,7 +313,7 @@ struct acpi_table_header *acpi_tb_table_override(struct acpi_table_header
return (NULL); /* There was no override */
- finish_override:
+finish_override:
ACPI_INFO((AE_INFO,
"%4.4s %p %s table override, new table: %p",
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 4/6] In acpi_tb_install_table()
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
` (2 preceding siblings ...)
2013-03-05 8:23 ` [PATCH 3/6] In acpi_tb_table_override() Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
2013-03-05 8:23 ` [PATCH 5/6] In acpi_initialize_tables() Tang Chen
2013-03-05 8:23 ` [PATCH 6/6] In Documentation/hw_random.txt Tang Chen
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/acpi/acpica/tbutils.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c
index ce3d5db..27e7715 100644
--- a/drivers/acpi/acpica/tbutils.c
+++ b/drivers/acpi/acpica/tbutils.c
@@ -539,7 +539,7 @@ acpi_tb_install_table(acpi_physical_address address,
acpi_tb_delete_table(table_desc);
}
- unmap_and_exit:
+unmap_and_exit:
/* Always unmap the table header that we mapped above */
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 5/6] In acpi_initialize_tables()
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
` (3 preceding siblings ...)
2013-03-05 8:23 ` [PATCH 4/6] In acpi_tb_install_table() Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
2013-03-05 8:23 ` [PATCH 6/6] In Documentation/hw_random.txt Tang Chen
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
In the comment of acpi_initialize_tables(), it mistakes allow_resize
with allow_realloc.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
drivers/acpi/acpica/tbxface.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
index 93d1432..659e0f6 100644
--- a/drivers/acpi/acpica/tbxface.c
+++ b/drivers/acpi/acpica/tbxface.c
@@ -80,7 +80,7 @@ acpi_status acpi_allocate_root_table(u32 initial_table_count)
* array is dynamically allocated.
* initial_table_count - Size of initial_table_array, in number of
* struct acpi_table_desc structures
- * allow_realloc - Flag to tell Table Manager if resize of
+ * allow_resize - Flag to tell Table Manager if resize of
* pre-allocated array is allowed. Ignored
* if initial_table_array is NULL.
*
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 6/6] In Documentation/hw_random.txt
2013-03-05 8:23 [PATCH 0/6] Fix some coding style and comment problems Tang Chen
` (4 preceding siblings ...)
2013-03-05 8:23 ` [PATCH 5/6] In acpi_initialize_tables() Tang Chen
@ 2013-03-05 8:23 ` Tang Chen
5 siblings, 0 replies; 7+ messages in thread
From: Tang Chen @ 2013-03-05 8:23 UTC (permalink / raw)
To: lenb, rjw, robert.moore, lv.zheng, ming.m.lin, mpm, herbert, rob
Cc: linux-acpi, linux-kernel, linux-doc, trival
Seeing from the comment, there are three reasons for removing request_mem_region.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
Documentation/hw_random.txt | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/hw_random.txt b/Documentation/hw_random.txt
index 690f525..026e237 100644
--- a/Documentation/hw_random.txt
+++ b/Documentation/hw_random.txt
@@ -63,7 +63,7 @@ Intel RNG Driver notes:
* FIXME: support poll(2)
- NOTE: request_mem_region was removed, for two reasons:
+ NOTE: request_mem_region was removed, for three reasons:
1) Only one RNG is supported by this driver, 2) The location
used by the RNG is a fixed location in MMIO-addressable memory,
3) users with properly working BIOS e820 handling will always
--
1.7.1
^ permalink raw reply [flat|nested] 7+ messages in thread